test(canary): parametrise canary detection across QMIA and LiRA#462
Merged
jim-smith merged 1 commit intoMay 26, 2026
Merged
Conversation
Merged
jim-smith
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #449
canary_targetfixture intests/conftest.pythat returns(target, canary_idx, n_train)bootstrap=FalseRandomForest, same as the original QMIA only testtests/attacks/test_canary_predictions.pyholds a parametrisedtest_attack_predicts_canariesover QMIA and LiRAmember_probvsscore), AUC threshold (0.90 vs 0.85, looser for shadow model attacks per the issue body), and canary count threshold (7/8 vs 6/8)test_qmia_predicts_canariesis removed to avoid drift, with a short comment intest_qmia_attack.pypointing at the new hometrain_test_splitof the combined train+test predictions, so the original training set'scanary_idxdoes not map directly intoinstance_0["individual"]["member_prob"]452-worstcase-report-individualso future WorstCase inclusion has the per record output availablemainwill be larger than the actual test: parametrise canary test across attacks (qmia, lira, worstcase) #449 change until both feat: MetaAttack model #441 and WorstCaseAttack to expose per-record scores #452 merge, after which a rebase will shrink it