Skip to content

feat(lira): rename per-record field from score to member_prob#463

Merged
JessUWE merged 1 commit into
mainfrom
450-lira-member-prob
Jun 11, 2026
Merged

feat(lira): rename per-record field from score to member_prob#463
JessUWE merged 1 commit into
mainfrom
450-lira-member-prob

Conversation

@shamykyzer

@shamykyzer shamykyzer commented May 25, 2026

Copy link
Copy Markdown
Contributor

closes #450

I rename LiRA's per record output field from "score" to "member_prob" so it matches QMIAAttack, touching likelihood_attack.py, meta_attack.py, report.py and their tests breaking, any LiRA report.json written before this needs regenerating before MetaAttack can read it in use_existing_only mode

@shamykyzer shamykyzer requested a review from jim-smith May 26, 2026 14:39
Base automatically changed from 449-parametrise-canary-test to 452-worstcase-report-individual May 26, 2026 15:54
@shamykyzer shamykyzer requested a review from rpreen May 28, 2026 08:58
@rpreen

rpreen commented May 28, 2026

Copy link
Copy Markdown
Contributor

This needs a clean up to resolve the conflicts and remove files not part of the description.

@shamykyzer shamykyzer force-pushed the 450-lira-member-prob branch from 7b3324d to ed2b524 Compare May 29, 2026 14:20
@shamykyzer shamykyzer force-pushed the 452-worstcase-report-individual branch from 217474f to e769ea1 Compare May 29, 2026 14:24
@shamykyzer shamykyzer force-pushed the 450-lira-member-prob branch from ed2b524 to d4f8934 Compare May 31, 2026 12:58
@shamykyzer shamykyzer changed the base branch from 452-worstcase-report-individual to main May 31, 2026 13:00
@shamykyzer shamykyzer linked an issue May 31, 2026 that may be closed by this pull request
@JessUWE JessUWE merged commit 85c9f0f into main Jun 11, 2026
1 check passed
@JessUWE JessUWE deleted the 450-lira-member-prob branch June 11, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardise per-record score field name across attacks

4 participants