Repository navigation
feat: support relocated transcripts when loading scans - #117
Open
YalcinkayaE wants to merge 2 commits into
Open
YalcinkayaE wants to merge 2 commits into
YalcinkayaE wants to merge 2 commits into
Conversation
alexandraabbas
left a comment
Collaborator
There was a problem hiding this comment.
Review posted on behalf of @alexandraabbas (written with Claude Code).
Thanks. The override itself is the right size: a keyword-only argument on load(), resolved and existence-checked in _transcripts_location(), no rewrite of the store, and the viewer and excerpt readers already read results.transcripts_location so nothing else needs to change. Points before merge:
Must fix
- Rebase and re-bump. The branch bumps 0.6.0 to 0.6.1, but
mainis at 0.7.0. Rebase and bump to 0.7.1. - Lockfile.
uv.lockchanges beyond the version line (lockrevision3 to 5, platform markers dropped onh11,truststore,ptyprocess,zstandard). That means it was re-locked with a different uv than CI pins (UV_VERSIONinci.yml). Please regenerate with the pinned uv so the lock diff is only the version bump. - Docs are three copies of the same paragraph. README, AGENTS.md and the using-transect skill each restate the full contract (resolves from cwd, raises on empty or missing, does not verify content, supply the same transcripts, keeps the recorded location when omitted). Keep the full statement in one place: the
load()docstring already has it. In README, fold a two-line mention into the existing "load() + render()" paragraph (around theresults.scan_locationadvice) instead of a new "Reloading moved transcripts" H2 section between Custom layers and Cost. In AGENTS.md, one sentence in the paragraph that already discussestranscripts_locationand snapshot directories is enough. The skill can say "passtranscripts_location=toload()after moving the source" and point at the docstring.
Trim the tests
test_load_repoints_moved_transcripts_without_rescanning does far more than the change needs, three times over (once per source kind):
- It runs a judged scan with
demo_judge(). The override is independent of judging; useSpec()with no judge so it stays a $0 structural scan. - It renders a full report, then asserts on the base64-encoded viewer path and excerpt HTML. Report rendering and the viewer link encoding are covered by the report tests already. Stop at: frames and
scan_statusequal,read_transcript_extras()returns excerpts from the new location, and_scan.jsonbytes unchanged. If you want one rendered check, do it for one source kind, not three.
The invalid-path test is fine as is.
YalcinkayaE
force-pushed
the
feat/transcripts-location
branch
from
November 5, 2026 10:58
94b0853 to
3e138aa
Compare
Author
|
The head moved after Alexandra Abbas's review at 10:05 Europe/London. Current head 3e138aa was committed at 10:53:16 Europe/London on 5 November 2026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #20. Independent of #105.
After moving a scan's source transcripts,
load(scan_location, transcripts_location=...)restores source viewing from the new local eval-log file, log directory or retained transcript database. The keyword-only override is resolved and existence-checked in_transcripts_location(); existing excerpt readers and viewer links already consume the resulting location.The full contract stays in the
load()docstring. README and AGENTS.md now give short mentions in their existing load/snapshot discussions, and the using-transect skill points to the docstring.Relocation tests now use
Spec()with structural scans. They stop at unchanged frames and scan status, excerpts read from the moved source, unchanged_scan.jsonbytes and absence of rescanning. Invalid-path coverage remains. The extra report-rendering and encoded-link assertions were removed.Rebased onto current main and bumped to 0.7.1. The lockfile diff contains only Transect's package-version line; dependency pins, platform markers and the seven-day cooldown are unchanged.
uv lock --checkanduv sync --lockedpass with CI's pinned uv 0.13.5.Validation
make check: 674 passed, 10 skipped; Ruff, formatting, mypy and Pyright pass.AI assistance: implementation and tests prepared with Codex. The relocation tests use structural scans and make no paid model calls.