Repository navigation
[codex] Fix NEP parity tick alignment - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NEP parity plot tick alignment so the x and y axes use the same tick positions when their limits are shared.
Root cause
The parity panels already used identical x/y limits, but Matplotlib selected ticks independently for each axis. In non-square panels such as subplot (d) in
nep_train.png, that could produce different x-axis and y-axis tick labels despite equal numeric ranges.Changes
Validation
python -m pytest tests\test_training_nep.pypython -m pytest