Repository navigation
Support element and direction combinations in partial SED postprocessing - #102
Merged
Tingliangstu merged 2 commits intoNov 4, 2026
Merged
Conversation
Tingliangstu
merged commit Nov 4, 2026
b0927d2
into
codex/pysed-3.0-architecture
10 of 16 checks passed
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved partial SED components can now be combined for plotting and fitting, for example
plot_partial_SED = Sr+Ti x+zorplot_partial_SED = all x. This addresses the element-group and whole-system directional workflows discussed in #63 and #81 through postprocessing of existingoutput_partial = 1files.Changes
+selections for elements and Cartesian directions; omitted directions mean x+y+z. Preserve the existingSrandSr xbehavior and figure names.save_partial_SED = 1by default to export only the selected sum beside the figures. Set it to0to skip export. Saved sums retain the full frequency grid and linear intensities; original components are unchanged.all, and report invalid selections, missing components, mismatched shapes, and inconsistent scales.SED computation, FFTs, normalization, and CPU/GPU kernels are unchanged. Only code, documentation, and tests are included; no trajectory data, calculation results, or generated images are uploaded. This PR is independent of the q-path changes in #101.
Validation
python -m unittest tests.test_partial_sed tests.test_pipeline_io tests.test_cli -q— 46 tests passed.pysedenvironment:python -m unittest tests.test_partial_sed -q— 7 tests passed.-W --keep-going) andgit diff --checkpassed.264 != 256intests/io/test_text.py:161, two batch-size subtests); the same failure is present on the unchanged 3.0 base. The feature-branch job passed the other 122 tests. This PR does not change that Windows test or its trajectory reader.