Repository navigation
Support random vacancies with fixed-lattice SED references - #108
Merged
Tingliangstu merged 2 commits intoNov 9, 2026
Merged
Conversation
Collaborator
Author
|
@994336637 Thanks for your contribution in #105. I have implemented static-vacancy support for pySED 3.0 in this PR, addressing the vacancy/atom-count issue raised in #58. The workflow keeps the complete four-column Could you try the This implementation is ready for testing but not yet merged. Substitutional mass disorder from #105 remains a separate feature. |
This was referenced Nov 9, 2026
Tingliangstu
merged commit Nov 9, 2026
1e78373
into
codex/pysed-3.0-architecture
10 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static vacancies can now be generated and processed against pySED's complete fixed reference lattice. A trajectory contains only surviving atoms; the four-column
basis.inkeeps every reference site, and the optionaldefect_index_filemaps each site to a one-based trajectory index (0 means vacant).remove_vacancies(element, fraction, seed)and adefect_index.inwriter. GPUMD and LAMMPS structures retain the surviving atom order.Validation:
pysed: 150 tests and 433 subtests passed, with CPU affinity restricted to one CPU and native threads limited to one.git diff --checkpassed.Known baseline CI issue: the existing Windows progress-byte-count test (
test_progress_offsets_and_partial_final_batch) fails with 264 versus 256 bytes on the unchanged 3.0 base. This PR leaves that unrelated test unchanged.Only code, documentation, and tests are included. Trajectories, calculated spectra, and generated images are excluded.