Fix/judge resolution fallback#381
Merged
Nicola Franco (franconicola) merged 6 commits intoMay 22, 2026
Merged
Conversation
… default When the orchestrator runs the post-attack evaluation pipeline, it calls _resolve_judges_from_config() with no arguments on the attack_config. The method correctly checked for a 'judges' list but skipped the common 'judge' dict format used by Ollama/local examples, falling through to the hardcoded 'gpt-4-0613' default and crashing with a missing-credentials error for users without an OpenAI API key. Resolution order is now: 1. 'judges' list in raw config 2. 'judge' dict in raw config (wrapped in a list) 3. technique_params fallback 4. gpt-4-0613 / jailbreakbench hardcoded defaults Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove all gpt-4/gpt-4o-mini hardcoded defaults from attacks, techniques, and judge resolution so the tool works without any external API key. Changes: - evaluation_step._resolve_judges_from_config: default_judge now uses DEFAULT_JUDGE_IDENTIFIER (gemma3:4b via Ollama) with default_type 'harmbench' instead of 'gpt-4-0613'/'jailbreakbench'. Also injects the Ollama endpoint/agent_type when the built-in default is used. - flipattack/attack.py: goal metadata judge default changed from 'gpt-4-0613' to DEFAULT_JUDGE_IDENTIFIER. - cli/tui/attack_specs.py: PAIR attacker default changed from 'gpt-4' and PAP attacker default changed from 'gpt-4o-mini' to DEFAULT_ATTACKER_IDENTIFIER (gemma3:4b).
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Enables auto-merge (squash) for all dependabot PRs targeting main. GitHub will merge automatically once all required CI checks pass.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
I merged latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.