Add editor.html login-screen screenshot test; style device-auth link as a button - #573
Merged
Merged
Conversation
…as a button The device-authorization "Open approval page" link was a bare <a> tag, easy to miss next to the styled Login/Cancel buttons. Render it as a reshaped Button (href renders an <a> under the hood) so it matches the rest of the login flow.
Mocks the device-code/token endpoints and freezes the page clock (Playwright's clock API) so the live countdown renders deterministically, then screenshots the polling state to lock in the "Open approval page" button styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/tests/editor-login-visual.spec.ts, a Playwright screenshot test that loadseditor.html(real-auth mode, no persisted token) and asserts it lands on the "Not logged in yet?" login screen, with atoHaveScreenshotvisual regression check.<a>tag that didn't visually match the surrounding Login/Cancel buttons. It now renders as a reshapedButton(href+attributes.target/rel), so it renders as a styled<a>that looks like the other buttons.Test plan
npm run typechecknpx eslint src/pages/app/index.tsx tests/editor-login-visual.spec.tsnpx playwright test tests/editor-login-visual.spec.ts(verified locally against/opt/pw-browsers/chromium, generating the baseline snapshot; not committed with an executablePath override — CI uses its own pinned browser install)/auth/device/code) to confirm the "Open approval page" link now renders as a button🤖 Generated with Claude Code
https://claude.ai/code/session_01RNp4SBCgAxVi442D3v8PWc
Generated by Claude Code