Deploy the mindmap to GitHub Pages - #593
Open
nhyiramante1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the GitHub Pages deployment path for
prototype-mindmap, so the tool can be served at its own origin (https://mindmap.thoughtful-ai.com/) rather than from the add-in container.Nothing here deploys anything. The workflow only deploys on a manual
workflow_dispatchfrommain; pull requests build and verify only.What's here
.github/workflows/deploy-mindmap-pages.yml— build-and-verify on PRs; deploy only via manual dispatch frommain. Read-only permissions for the build job;pages: write/id-token: writescoped to the deploy job.scripts/verify-pages-build.mjs+npm run verify:pages— fails the build if the backend URL is missing/malformed/not HTTPS, ifdist/index.htmlis absent, if the production API base doesn't appear in the compiled output, or if a localhost reference or.envfile made it into the artifact.e2e-pages/+playwright.pages.config.ts+npm run test:e2e:pages— Playwright run against the compileddistviavite preview: launch gate on direct access, mocked grant exchange, launch params scrubbed from the URL, bearer on subsequent requests, no console/asset errors. The existing dev-server suite is unchanged.mindmap-tests.yml— runs the production build, artifact verification, and the new production-bundle smoke..env.production— public browser config only (VITE_BACKEND_URL,VITE_REQUIRE_LAUNCH). No secrets reach the Pages build. Provider transport/model/reasoning-effort intentionally inherit theirapi.tsdefaults rather than being duplicated here.Vite's base stays at root — the mindmap has no client-side routing, so no
404.htmlor SPA fallback is needed. NoCNAMEis checked in.One test is deliberately skipped
e2e-pages/pages-smoke.spec.ts:110is marked:It asserts a launch uses the platform-supplied API base rather than the build-time fallback, and that the build-time backend receives no request. That contract only exists in #579, so it can't run yet.
Before this can merge
main.wt_apismoke test is unskipped and green.mindmapisn't in the tool allowlist yet).mindmap.thoughtful-ai.comCNAME'd toaitoolslab.github.io, Pages enabled with the custom domain, and HTTPS issued. GitHub allows up to 24h for the certificate — until it's live the site is http-only, and with origin bindinghttp://won't match the launchedhttps://, so launches fail in that window. Expected, not a bug.The mindmap tile also stays off until the add-in is rebuilt with
VITE_ENABLE_MINDMAP_TOOL=true— that's a separate build and not affected by anything in this PR.