chore: cover the quarantine scope with a changeset - #270
Merged
Conversation
packages/contracts and packages/cli both changed in #254 with nothing to release them. Left alone, the pending release publishes the CLI while the contracts package stays at a version whose TokenScope union has no `quarantine` in it — so an API that accepts the scope and a published type that does not know it exist at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working out whether the release PR (#249) was safe to merge. It is not, yet.
#254 changed two published packages and shipped no changeset:
#249 was cut before that landed, so merging it as-is publishes
@flakemetry/cli@0.2.0with a changelog describing onlyrun/flaky/doctor, and publishes nothing for contracts.The second half is the part that matters.
@flakemetry/contractson npm would keep aTokenScopeunion of'ingest' | 'read'while the API happily acceptsquarantine— so anyone typing against the published package gets a compile error for a scope the server supports, and nothing anywhere would explain why.This adds the changeset. The release bot will fold it into #249, which can then publish both packages together and describe what actually changed.