[FINDING-067] Qualify RIP-25 asset phase for 4.8.1

.github/workflows/build-raven.yml

@@ -59,13 +59,22 @@ jobs:
         run: |
           ./autogen.sh
           mkdir -p "$HOME/.ccache"
+          "$PWD/depends/x86_64-pc-linux-gnu/native/bin/ccache" --print-config > /dev/null
           CONFIG_SITE="$PWD/depends/x86_64-pc-linux-gnu/share/config.site" \
-            ./configure --without-gui --disable-bench
+            ./configure --without-gui --with-tx --disable-bench
 
       - name: Build and run unit tests
         run: |
           make -j2
-          make check
+          if ! make check; then
+            for log in src/test-suite.log src/test/test_raven.log; do
+              if [ -f "$log" ]; then
+                echo "Failure details from $log:"
+                tail -n 160 "$log"
+              fi
+            done
+            exit 1
+          fi
 
       - name: Exercise the real PQ verifier fuzz target
         run: |
@@ -81,8 +90,8 @@ jobs:
         run: |
           python3 contrib/devtools/test-required-functional-gate.py
           python3 test/functional/test_runner.py --require-tests --jobs=2 \
-            wallet_encryption_rewrite.py wallet_asset_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py \
-            feature_asset_activation_reorg.py feature_transfer_script_reorg.py feature_rip5_activation_reorg.py \
+            wallet_encryption_rewrite.py wallet_asset_multiwallet.py feature_rewards_restart.py wallet_pq_recovery.py wallet_restricted_multiwallet.py wallet_messaging_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py \
+            feature_asset_activation_reorg.py feature_pq_activation_reorg_sigops.py feature_transfer_script_reorg.py feature_rip5_activation_reorg.py feature_enforced_coinbase_activation.py \
             feature_asset_dbcrash.py feature_asset_dbcrash_transfer.py feature_asset_db_missing_block.py \
             feature_asset_verifydb_sameblock.py feature_transfer_mempool_reorg.py feature_mempool_clear_reissue.py feature_mempool_reissue_restart.py feature_transfer_sidebranch.py feature_pq_asset_anchor.py feature_pq_asset_authority_selection.py feature_pq_asset_source_rpc.py feature_pq_asset_wallet_ownership.py feature_loadblock.py \
             feature_restricted_dbcrash.py feature_restricted_verifydb.py feature_restricted_verifydb_root.py \
@@ -227,6 +236,7 @@ jobs:
       run: |
         ./autogen.sh
         mkdir -p "$HOME/.ccache"
+        "$PWD/depends/${{ matrix.host }}/native/bin/ccache" --print-config > /dev/null
 
     - name: Configure Build
       run: bash -Eeuo pipefail "${SCRIPTS}/04-configure-build.sh" "${{ matrix.OS }}" "$GITHUB_WORKSPACE"
@@ -240,6 +250,34 @@ jobs:
     - name: Build Raven
       run: make -j2
 
+    - name: Install Qt runtime test prerequisites
+      if: matrix.OS == 'linux'
+      run: sudo apt-get install -y xvfb xauth x11-utils libxtst6 libxkbcommon-x11-0
+
+    - name: Verify Qt smoke runtime libraries
+      if: matrix.OS == 'linux'
+      shell: bash
+      run: |
+        for binary in src/qt/raven-qt src/raven-cli; do
+          test -x "$binary"
+          libraries="$(ldd "$binary")"
+          if grep -Fq 'not found' <<< "$libraries"; then
+            printf 'Missing runtime libraries for %s:\n%s\n' "$binary" "$libraries"
+            exit 1
+          fi
+        done
+
+    - name: Test Qt startup without wallet
+      if: matrix.OS == 'linux'
+      run: ./contrib/devtools/test-qt-no-wallet-startup.sh
+
+    - name: Test Qt Options without wallet
+      if: matrix.OS == 'linux'
+      run: |
+        xvfb-run -a -s '-screen 0 1024x768x24' \
+          python3 contrib/devtools/test-qt-no-wallet-options.py \
+          src/qt/raven-qt src/raven-cli
+
 # Skip the binary checks for now.
 #      name: Check Binary Security
 #      run: ${SCRIPTS}/05-binary-checks.sh ${{ MATRIX.OS }} ${{ GITHUB.WORKSPACE }}

.github/workflows/rip25-v48-final-gate.yml

@@ -72,8 +72,9 @@ jobs:
         run: |
           ./autogen.sh
           mkdir -p "$HOME/.ccache"
+          "$PWD/depends/x86_64-pc-linux-gnu/native/bin/ccache" --print-config > /dev/null
           CONFIG_SITE="$PWD/depends/x86_64-pc-linux-gnu/share/config.site" \
-            ./configure --without-gui --disable-bench
+            ./configure --without-gui --with-tx --disable-bench
 
       - id: build_tests
         name: Build tests
@@ -103,8 +104,8 @@ jobs:
         run: |
           python3 contrib/devtools/test-required-functional-gate.py
           python3 test/functional/test_runner.py --require-tests --jobs=2 \
-            wallet_encryption_rewrite.py wallet_asset_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py \
-            feature_asset_activation_reorg.py feature_transfer_script_reorg.py feature_rip5_activation_reorg.py \
+            wallet_encryption_rewrite.py wallet_asset_multiwallet.py feature_rewards_restart.py wallet_pq_recovery.py wallet_restricted_multiwallet.py wallet_messaging_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py \
+            feature_asset_activation_reorg.py feature_pq_activation_reorg_sigops.py feature_transfer_script_reorg.py feature_rip5_activation_reorg.py feature_enforced_coinbase_activation.py \
             feature_asset_dbcrash.py feature_asset_dbcrash_transfer.py feature_asset_db_missing_block.py \
             feature_asset_verifydb_sameblock.py feature_transfer_mempool_reorg.py feature_mempool_clear_reissue.py feature_mempool_reissue_restart.py feature_transfer_sidebranch.py feature_pq_asset_anchor.py feature_pq_asset_authority_selection.py feature_pq_asset_source_rpc.py feature_pq_asset_wallet_ownership.py feature_loadblock.py \
             feature_restricted_dbcrash.py feature_restricted_verifydb.py feature_restricted_verifydb_root.py \
@@ -218,6 +219,7 @@ jobs:
         run: |
           ./autogen.sh
           mkdir -p "$HOME/.ccache"
+          "$PWD/depends/${{ matrix.host }}/native/bin/ccache" --print-config > /dev/null
           CONFIG_SITE="$PWD/depends/${{ matrix.host }}/share/config.site" \
             ./configure ${{ matrix.configure_flags }}
 

README.md

@@ -7,37 +7,33 @@ https://ravencoin.org
 
 ## RIP-25: Post-Quantum Signatures (This Fork)
 
-This fork implements [RIP-25](doc/RIP-0025-PQ-Signatures.md) ([GitHub Issue #1280](https://github.com/RavenProject/Ravencoin/issues/1280)), a proposal to add **quantum-resistant native RVN transaction signing** to Ravencoin using ML-DSA-44 (FIPS 204).
+This fork implements [RIP-25](doc/RIP-0025-PQ-Signatures.md) ([GitHub Issue #1280](https://github.com/RavenProject/Ravencoin/issues/1280)), which adds **quantum-resistant native RVN transaction signing** using ML-DSA-44 (FIPS 204). The 4.8.1 candidate adds a separate bit-13 rule for new asset and owner-token outputs.
 
 ### What it does
 
-New **witness v2** addresses use ML-DSA-44 (a NIST-standardized post-quantum signature algorithm) exclusively. Existing ECDSA addresses (witness v0) continue working unchanged. Users can migrate native RVN from ECDSA to ML-DSA-44 addresses before quantum computers can break ECDSA. Ravencoin assets remain on their legacy ownership conditions and are outside the current RIP-25 scope.
+New **witness v2** addresses use ML-DSA-44 (a NIST-standardized post-quantum signature algorithm) exclusively. Existing ECDSA addresses continue working unchanged. Users can migrate native RVN to ML-DSA-44 addresses voluntarily. The original bit-12 rule does not change legacy asset ownership. Once bit 13 activates, newly created asset and owner-token outputs require a matching native RVN witness-v2 ML-DSA anchor when spent, with no ECDSA asset signature. Historical outputs retain their classical spending rule until their owners migrate them.
 
-- **Old addresses (witness v0):** ECDSA/secp256k1, unchanged
-- **New addresses (witness v2):** ML-DSA-44 only, quantum-resistant
+- **Classical addresses:** ECDSA/secp256k1, unchanged
+- **PQ addresses (witness v2):** ML-DSA-44 only, quantum-resistant
 - **Migration:** Users send native RVN from old to new addresses at their own pace
-- **Assets:** Normal, owner, reissuable, unique, restricted, and qualifier assets are not protected by RIP-25
+- **Assets:** New post-bit-13 asset and owner-token outputs require an ML-DSA anchor; historical holdings remain classical until voluntary migration
 
 ### Key changes
 
 | Area | Change |
 |------|--------|
-| **Consensus** | BIP9 soft-fork deployment (bit 12, 85% threshold), phased block weight increase (8 → 12 → 16 MWU) |
+| **Consensus** | Bit-12 BIP9 signaling (1714 of 2016); incompatible 8 to 12 to 16 MWU block-limit transition and contextual PQ witness discount |
 | **Script** | Witness version 2 validation: 2-element witness stack [mldsa_sig, mldsa_pk], SHA256(pk) == program |
-| **Policy** | `TX_WITNESS_V2_PQ_KEYHASH` standard type, PQ witness discount (8x), PQ-aware dust threshold |
+| **Policy** | `TX_WITNESS_V2_PQ_KEYHASH` standard type and PQ-aware dust threshold |
 | **Addresses** | Bech32m encoding for witness v2 (HRP: `rvn` mainnet, `trvn` testnet, `rcrt` regtest) |
 | **Network** | `NODE_PQ_HYBRID` service flag (bit 5), 16 MB protocol message limit |
-| **Crypto** | `src/crypto/mldsa.h/cpp` — ML-DSA-44 via [liboqs](https://github.com/open-quantum-safe/liboqs) (FIPS 204 compliant) |
-| **Keys** | `src/pqkey.h/cpp` — `CPQKey` / `CPQPubKey` for ML-DSA-44 key management |
+| **Crypto** | `src/crypto/mldsa.h/cpp`: ML-DSA-44 via [liboqs](https://github.com/open-quantum-safe/liboqs) (FIPS 204 compliant) |
+| **Keys** | `src/pqkey.h/cpp`: `CPQKey` / `CPQPubKey` for ML-DSA-44 key management |
 | **Wallet** | `getnewpqaddress` RPC, PQ keystore integration, `IsMine` for witness v2 |
-| **Assets** | Existing asset scripts remain legacy P2PKH-only; witness-v2 PQ destinations protect native RVN only |
+| **Assets** | Bit 13 adds PQ-only asset carriers paired with native RVN witness-v2 inputs; historical asset outputs remain classically spendable |
 | **Signing** | ML-DSA-44 signing in `sign.cpp` via `TransactionSignatureCreator` |
 | **Build** | liboqs added as dependency (`depends/packages/liboqs.mk`, `configure.ac --with-liboqs`) |
-| **Tests** | `src/test/pqkey_tests.cpp` — unit tests for ML-DSA-44 keygen, sign/verify, witness programs |
-
-### Branch
-
-Audit and remediation work is on [`fix/rip25-v48-glm-remediation`](https://github.com/ALENOC/Ravencoin/tree/fix/rip25-v48-glm-remediation).
+| **Tests** | `src/test/pqkey_tests.cpp`: unit tests for ML-DSA-44 keygen, sign/verify, witness programs |
 
 ### Building with liboqs
 

configure.ac

@@ -2,7 +2,7 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
 AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 4)
 define(_CLIENT_VERSION_MINOR, 8)
-define(_CLIENT_VERSION_REVISION, 0)
+define(_CLIENT_VERSION_REVISION, 1)
 define(_CLIENT_VERSION_BUILD, 0)
 define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)

contrib/devtools/check-rip25-v48-invariants.sh

@@ -91,6 +91,21 @@ require_fixed 'feature_pq_asset_source_rpc.py' .github/workflows/build-raven.yml
 require_fixed 'feature_pq_asset_wallet_ownership.py' test/functional/test_runner.py 'PQ asset wallet ownership regression is not registered'
 require_fixed 'feature_mempool_clear_reissue.py' test/functional/test_runner.py 'mempool clear reissue regression is not registered'
 require_fixed 'feature_mempool_reissue_restart.py' test/functional/test_runner.py 'mempool reissue restart regression is not registered'
+require_fixed "'feature_rewards_restart.py'" test/functional/test_runner.py 'reward restart regression is not registered'
+require_fixed 'feature_rewards_restart.py' .github/workflows/rip25-v48-final-gate.yml 'final gate omits reward restart regression'
+require_fixed 'feature_rewards_restart.py' .github/workflows/build-raven.yml 'release workflow omits reward restart regression'
+require_fixed "'wallet_pq_recovery.py'" test/functional/test_runner.py 'PQ wallet recovery regression is not registered'
+require_fixed 'wallet_pq_recovery.py' .github/workflows/rip25-v48-final-gate.yml 'final gate omits PQ wallet recovery regression'
+require_fixed 'wallet_pq_recovery.py' .github/workflows/build-raven.yml 'release workflow omits PQ wallet recovery regression'
+require_fixed "'wallet_restricted_multiwallet.py'" test/functional/test_runner.py 'restricted multiwallet regression is not registered'
+require_fixed 'wallet_restricted_multiwallet.py' .github/workflows/rip25-v48-final-gate.yml 'final gate omits restricted multiwallet regression'
+require_fixed 'wallet_restricted_multiwallet.py' .github/workflows/build-raven.yml 'release workflow omits restricted multiwallet regression'
+require_fixed "'wallet_messaging_multiwallet.py'" test/functional/test_runner.py 'messaging multiwallet regression is not registered'
+require_fixed 'wallet_messaging_multiwallet.py' .github/workflows/rip25-v48-final-gate.yml 'final gate omits messaging multiwallet regression'
+require_fixed 'wallet_messaging_multiwallet.py' .github/workflows/build-raven.yml 'release workflow omits messaging multiwallet regression'
+require_fixed "'feature_pq_activation_reorg_sigops.py'" test/functional/test_runner.py 'PQ activation reorg and sigop regression is not registered'
+require_fixed 'feature_pq_activation_reorg_sigops.py' .github/workflows/rip25-v48-final-gate.yml 'final gate omits PQ activation reorg and sigop regression'
+require_fixed 'feature_pq_activation_reorg_sigops.py' .github/workflows/build-raven.yml 'release workflow omits PQ activation reorg and sigop regression'
 
 # GLM-003: contextual 8 -> 12 -> 16 MWU and UTXO-bound 8x discount.
 require_fixed 'VersionBitsStateSinceHeight' src/validation.cpp 'deterministic RIP-25 phase boundary missing'
@@ -619,12 +634,17 @@ require_fixed 'python3 contrib/devtools/test-required-functional-gate.py' "$fina
 require_fixed 'python3 test/functional/test_runner.py --require-tests' "$final_gate" 'functional gate permits absent or skipped security tests'
 require_fixed 'feature_mempool_clear_reissue.py' "$final_gate" 'final gate omits inherited mempool clear regression'
 require_fixed 'feature_mempool_reissue_restart.py' "$final_gate" 'final gate omits inherited reissue restart regression'
-require_fixed 'wallet_encryption_rewrite.py wallet_asset_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py' "$final_gate" 'required wallet, multiwallet asset, asset-scope, and chainstate-ahead functional tests are missing'
+require_fixed 'wallet_encryption_rewrite.py wallet_asset_multiwallet.py feature_rewards_restart.py wallet_pq_recovery.py wallet_restricted_multiwallet.py wallet_messaging_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py' "$final_gate" 'required wallet, rewards, PQ recovery, restricted multiwallet, messaging multiwallet, asset-scope, and chainstate-ahead functional tests are missing'
 require_fixed 'wallet_asset_multiwallet.py' .github/workflows/build-raven.yml 'release security job omits the multiwallet asset regression'
 require_fixed "'wallet_asset_multiwallet.py'" test/functional/test_runner.py 'multiwallet asset regression is not in the functional suite'
 require_fixed 'id: posttest_integrity' "$final_gate" 'final gate does not recheck source after security tests'
 final_security_job="$(sed -n '/^  security-tests:/,/^  build:/p' "$final_gate")"
 require_text "$final_security_job" 'test/test_raven_fuzzy --pq-smoke' 'final security job does not run the PQ verifier fuzz smoke test'
+mapfile -t final_security_sha_lines < <(grep -nFx '          test "$(git rev-parse HEAD)" = "$GITHUB_SHA"' <<<"$final_security_job" | cut -d: -f1)
+(( ${#final_security_sha_lines[@]} == 2 )) || fail 'final security job must execute exact-SHA checks before and after tests'
+final_make_check_line="$(grep -nFx '        run: make check' <<<"$final_security_job" | cut -d: -f1 || true)"
+[[ "$final_make_check_line" =~ ^[0-9]+$ ]] || fail 'final security job does not execute make check'
+(( final_security_sha_lines[0] < final_make_check_line && final_make_check_line < final_security_sha_lines[1] )) || fail 'final security job does not bracket make check with exact-SHA checks'
 require_fixed 'id: postbuild_integrity' "$final_gate" 'final gate does not recheck source after cross-builds'
 final_build_matrix="$(sed -n '/^      matrix:/,/^    steps:/p' "$final_gate")"
 require_text "$final_build_matrix" $'          - name: aarch64-disable-wallet\n            host: aarch64-linux-gnu\n            packages: g++-aarch64-linux-gnu\n            configure_flags: --without-gui --disable-wallet --disable-bench\n            run_tests: false' 'final gate lacks the aarch64 no-wallet cross-build'
@@ -667,7 +687,12 @@ require_text "$release_security_job" 'feature_mempool_clear_reissue.py' 'release
 require_text "$release_security_job" 'feature_mempool_reissue_restart.py' 'release artifact workflow omits inherited reissue restart regression'
 require_text "$release_security_job" 'feature_chainstate_ahead.py' 'release artifact workflow does not test chainstate-ahead recovery'
 require_text "$release_security_job" 'test "$(git rev-parse HEAD)" = "$GITHUB_SHA"' 'release security job does not bind tests to the artifact SHA'
-require_text "$release_build_job" '    needs: security-tests' 'release artifact matrix can package without passing security tests'
+grep -Fxq '    needs: security-tests' <<<"$release_build_job" || fail 'release artifact matrix can package without passing security tests'
+mapfile -t release_security_sha_lines < <(grep -nFx '          test "$(git rev-parse HEAD)" = "$GITHUB_SHA"' <<<"$release_security_job" | cut -d: -f1)
+(( ${#release_security_sha_lines[@]} == 2 )) || fail 'release security job must execute exact-SHA checks before and after tests'
+release_make_check_line="$(grep -nFx '          if ! make check; then' <<<"$release_security_job" | cut -d: -f1 || true)"
+[[ "$release_make_check_line" =~ ^[0-9]+$ ]] || fail 'release security job does not execute make check'
+(( release_security_sha_lines[0] < release_make_check_line && release_make_check_line < release_security_sha_lines[1] )) || fail 'release security job does not bracket make check with exact-SHA checks'
 release_matrix="$(sed -n '/^      matrix:/,/^    steps:/p' "$release_workflow")"
 release_axes="$(grep -E '^        [A-Za-z_][A-Za-z_0-9]*:' <<<"$release_matrix" || true)"
 [[ "$release_axes" == '        include:' ]] || fail 'release workflow has unexpected matrix axes'
@@ -723,6 +748,8 @@ if [[ "$mode" == '--structural-only' ]]; then
   exit 0
 fi
 
+python3 contrib/devtools/test-rip25-invariant-gate-negative-controls.py
+
 test_binary=src/test/test_raven
 [[ -x "$test_binary" ]] || fail "behavioral test binary is missing or not executable: $test_binary"
 # Qt and benchmark translation units are not linked into the headless
@@ -804,7 +831,8 @@ echo "$fuzz_smoke_output"
 "$fuzz_binary" --pq-seed-tx | "$fuzz_binary"
 
 python3 contrib/devtools/test-required-functional-gate.py
+PYTHONPATH=test/functional python3 -m unittest test_framework.test_cache_peers
 python3 test/functional/test_runner.py --require-tests --jobs=2 \
-  wallet_encryption_rewrite.py rpc_assettransfer.py feature_chainstate_ahead.py feature_pq_asset_anchor.py feature_pq_asset_authority_selection.py feature_pq_asset_source_rpc.py feature_pq_asset_wallet_ownership.py feature_mempool_clear_reissue.py feature_mempool_reissue_restart.py
+  wallet_encryption_rewrite.py feature_rewards_restart.py wallet_pq_recovery.py wallet_restricted_multiwallet.py wallet_messaging_multiwallet.py rpc_assettransfer.py feature_chainstate_ahead.py feature_pq_activation_reorg_sigops.py feature_pq_asset_anchor.py feature_pq_asset_authority_selection.py feature_pq_asset_source_rpc.py feature_pq_asset_wallet_ownership.py feature_mempool_clear_reissue.py feature_mempool_reissue_restart.py
 
 echo 'RIP-25/v4.8 structural + behavioral invariants: OK'