Apptainer support - #1
Merged
Merged
Conversation
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
mawad-amd
approved these changes
Feb 3, 2025
| #!/bin/bash | ||
|
|
||
| timestamp=$(date +"%Y%m%d_%H%M%S") | ||
|
|
Member
There was a problem hiding this comment.
How about we add this?
Suggested change
| # Make sure we start the SSH agent | |
| eval `ssh-agent -s` | |
| [ -f ~/.ssh/id_rsa ] && ssh-add ~/.ssh/id_rsa | |
| [ -f ~/.ssh/id_ed25519 ] && ssh-add ~/.ssh/id_ed25519 |
Collaborator
Author
There was a problem hiding this comment.
I like the idea, but I've found scripts like this can inadvertently create duplicate ssh-agents. For my own usage, I use a script similar to this in my ~/.bashrc:
if [ ! -S ~/.ssh/ssh_auth_sock ]; then
eval `ssh-agent` > /dev/null
ln -sf "$SSH_AUTH_SOCK" ~/.ssh/ssh_auth_sock
fi
export SSH_AUTH_SOCK=~/.ssh/ssh_auth_sock
ssh-add -l > /dev/null || ssh-addThis way, we're always re-using the same ssh-agent. Let me find a middle ground between both of these solutions and add it to the script
While not comprehensive, this adds basic SSH keys to the agent Signed-off-by: coleramos425 <colramos@amd.com>
mehdi-saeedi
added a commit
that referenced
this pull request
Feb 23, 2026
Fix/nmse validation for llama.cpp kernels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Apptainer support to the maestro project. The definition (
.def) file pulls in all the software dependencies:Use the shell script
run.shto build the image (.sif) file.