Conversation
Implemented core public API classes and internal modules: Public API: - config.py: ValidationConfig and KernelArg classes * Structured kernel arguments with name, type, direction * Backward compatible with strings and dicts * Support for additional_includes for custom types - result.py: ValidationResult and ArrayMismatch classes * Detailed validation results with metrics * Human-readable summary() method - exceptions.py: Custom exception hierarchy * AccordoError, AccordoBuildError, AccordoTimeoutError * AccordoProcessError, AccordoValidationError Internal modules (_internal/): - codegen.py: Header generation with additional_includes support - hip.py: HIP interop (open_ipc_handle, memcpy_d2h) - ipc/communication.py: IPC communication with dynamic timeout Updated __init__.py to export clean public API. Added README_REFACTORING.md documenting progress. TODO: - Implement AccordoValidator class - Builder and Runtime modules - Integration with formula_base.py - Tests See accordo.todo for complete design.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ccordo improvements
mawad-amd
force-pushed
the
muhaawad/accordo
branch
from
November 3, 2025 10:01
d912860 to
f2c3160
Compare
- Add OptimizationTracker helper methods: is_successful(), get_best_code(), get_best_report(), get_best_metrics() - Add auto-determination of success based on improvement and speedup - Add _filter_compiler_errors() static method for cleaner compiler output - Add process crash detection in Accordo IPC with process_pid - Add enhanced timeout error messages with baseline context - Maintain all Accordo API improvements from feature branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.