Use nexus Python package - #158
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Muhammad Awad <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com> Co-authored-by: stephen youn <13525892+stephen-youn@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Co-authored-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Nexus integration by migrating from the C++ library API to the Python API, simplifying the codebase and removing manual build configuration. The changes also clean up unused utility functions and streamline the accordo path detection logic.
- Replaces Nexus C++ library usage with the Python API for kernel source code collection
- Removes deprecated helper functions
get_nexus_path()andget_accordo_path() - Adds Nexus as a pip-installable dependency from GitHub
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/intelliperf/utils/env.py | Removes get_accordo_path() and get_nexus_path() helper functions that are no longer needed |
| src/intelliperf/core/application.py | Refactors collect_source_code() to use Nexus Python API instead of C++ library via HSA_TOOLS_LIB |
| src/accordo/validator.py | Updates accordo path auto-detection to directly check relative paths instead of using removed get_accordo_path() |
| pyproject.toml | Adds nexus as a git-based dependency and removes manual build configuration for Nexus |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try: | ||
| from nexus import Nexus | ||
| except ImportError: | ||
| logging.error("Nexus Python API not found. Please install it: pip install nexus") |
There was a problem hiding this comment.
The error message suggests installing with pip install nexus, but the package is installed from a git repository. The message should be updated to match the actual installation method: pip install git+https://github.com/AMDResearch/nexus.git@main or reference the project's dependency installation process.
| logging.error("Nexus Python API not found. Please install it: pip install nexus") | |
| logging.error("Nexus Python API not found. Please install it: pip install git+https://github.com/AMDResearch/nexus.git@main") |
No description provided.