Additional metadata for kernel args - #159
Merged
Merged
Conversation
Signed-off-by: coleramos425 <colramos@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends Accordo's Snapshot functionality to capture GPU kernel dispatch dimensions (grid size and block/workgroup size) alongside kernel argument data. This enhancement provides additional context about kernel execution configuration, which is valuable for validation and debugging, specifically for kernel extraction tools.
Changes
Python API:
grid_sizeandblock_sizefieldsSnapshot.summary()to display grid/block dimensions when availablecapture_snapshot()to pass metadata file path via environment variableC++ Runtime Hook:
write_packets()when processingHSA_PACKET_TYPE_KERNEL_DISPATCHpacketsACCORDO_METADATA_FILEenvironment variableExample Usage
Output: