Skip to content

[DOCS] Update wh41n dataset, add license for noac47n and wh41n #112

Merged
eleanorfrajka merged 7 commits into
mainfrom
reports/2026-02-10
Feb 11, 2026
Merged

[DOCS] Update wh41n dataset, add license for noac47n and wh41n #112
eleanorfrajka merged 7 commits into
mainfrom
reports/2026-02-10

Conversation

@eleanorfrajka
Copy link
Copy Markdown
Collaborator

Description:

This PR updates the dataset for wh41n to the latest (v5) and adds the license CC-BY-4.0 to both the wh41n datasets and the noac47n dataset, based on response from Josh Willis (41°N) and Christian Mertens (47°N).

Other small changes:

  • in plotters.py change from units in square brackets to units in parentheses.
  • in plotters.py add units formatting for "degree_N" to "°N" and "m s-1" to "m/s".

Checklist:

  • I have followed the coding conventions.
  • I have updated or added tests to cover my changes.
  • I have updated the documentation if needed.
  • I have run pytest to check that all tests pass.
  • I have run pre-commit run --all-files to lint and format the code.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the wh41n dataset to version 5 and adds CC-BY-4.0 licenses to both wh41n and noac47n datasets based on feedback from the data providers. Additionally, it standardizes units formatting in plots from square brackets to parentheses and adds new unit conversions. Plot filenames are also normalized to lowercase.

Changes:

  • Updated wh41n dataset to v5 with new Zenodo record (18238115)
  • Added CC-BY-4.0 license to wh41n and noac47n metadata based on data provider feedback
  • Changed units formatting in plots from square brackets to parentheses (e.g., "[Sv]" → "(Sv)")
  • Added new unit conversions (degree_N → °N, m s-1 → m/s)
  • Normalized plot filenames to lowercase with underscores

Reviewed changes

Copilot reviewed 22 out of 56 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_readers.py Updated expected variable name for 41n dataset to match v5 format
notebooks/demo.ipynb Removed duplicate raw data loading cell
docs/source/reports/*.rst Updated report files with v5 data, license info, lowercase plot filenames, and processing version
amocatlas/metadata/wh41n.yml Added CC-BY-4.0 license, v5 version info, and variable mappings for new format
amocatlas/metadata/noac47n.yml Added CC-BY-4.0 license
amocatlas/data_sources/wh41n.py Updated Zenodo URLs, improved CSV parsing logic for v5 format
amocatlas/plotters.py Changed units formatting and added new unit conversions
amocatlas/report.py Normalized plot filenames to lowercase
.gitignore Updated patterns for ARGO data files
data/hobbs_willis_amoc41N_tseries_v2025_01.txt New v5 data file
docs/source/_static/reports/*.png Updated plot images with lowercase filenames

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread amocatlas/metadata/wh41n.yml Outdated
Comment thread amocatlas/data_sources/wh41n.py Outdated
@eleanorfrajka eleanorfrajka merged commit a379b61 into main Feb 11, 2026
4 checks passed
eleanorfrajka added a commit that referenced this pull request Feb 11, 2026
@eleanorfrajka eleanorfrajka deleted the reports/2026-02-10 branch February 23, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants