[DOCS] Update wh41n dataset, add license for noac47n and wh41n #112
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the wh41n dataset to version 5 and adds CC-BY-4.0 licenses to both wh41n and noac47n datasets based on feedback from the data providers. Additionally, it standardizes units formatting in plots from square brackets to parentheses and adds new unit conversions. Plot filenames are also normalized to lowercase.
Changes:
- Updated wh41n dataset to v5 with new Zenodo record (18238115)
- Added CC-BY-4.0 license to wh41n and noac47n metadata based on data provider feedback
- Changed units formatting in plots from square brackets to parentheses (e.g., "[Sv]" → "(Sv)")
- Added new unit conversions (degree_N → °N, m s-1 → m/s)
- Normalized plot filenames to lowercase with underscores
Reviewed changes
Copilot reviewed 22 out of 56 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_readers.py | Updated expected variable name for 41n dataset to match v5 format |
| notebooks/demo.ipynb | Removed duplicate raw data loading cell |
| docs/source/reports/*.rst | Updated report files with v5 data, license info, lowercase plot filenames, and processing version |
| amocatlas/metadata/wh41n.yml | Added CC-BY-4.0 license, v5 version info, and variable mappings for new format |
| amocatlas/metadata/noac47n.yml | Added CC-BY-4.0 license |
| amocatlas/data_sources/wh41n.py | Updated Zenodo URLs, improved CSV parsing logic for v5 format |
| amocatlas/plotters.py | Changed units formatting and added new unit conversions |
| amocatlas/report.py | Normalized plot filenames to lowercase |
| .gitignore | Updated patterns for ARGO data files |
| data/hobbs_willis_amoc41N_tseries_v2025_01.txt | New v5 data file |
| docs/source/_static/reports/*.png | Updated plot images with lowercase filenames |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the dataset for wh41n to the latest (v5) and adds the license CC-BY-4.0 to both the wh41n datasets and the noac47n dataset, based on response from Josh Willis (41°N) and Christian Mertens (47°N).
Other small changes:
plotters.pychange from units in square brackets to units in parentheses.plotters.pyadd units formatting for "degree_N" to "°N" and "m s-1" to "m/s".Checklist:
pytestto check that all tests pass.pre-commit run --all-filesto lint and format the code.