[FIX] Move fw2015 to zenodo for automatic downloads#115
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the FW2015 datasource to download from Zenodo instead of Figshare, addressing blocked downloads in AMOCatlas. It also includes regenerated documentation reports/plots and adds the Zenodo-hosted .mat file to the repo’s data/ directory.
Changes:
- Switch FW2015 download URLs/metadata from Figshare to Zenodo and update the default FW2015 filename to
MOCproxy_for_figshare_v1.0.mat. - Update FW2015 generated report metadata (weblink/source URL) to point to Zenodo.
- Regenerate several docs reports and static plots; add the new FW2015
.matfile todata/.
Reviewed changes
Copilot reviewed 6 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
amocatlas/data_sources/fw2015.py |
Updates FW2015 default filename and download URLs to Zenodo; sets Zenodo DOI. |
amocatlas/metadata/fw2015.yml |
Updates FW2015 metadata weblink and file source_url to Zenodo; renames file key to v1.0. |
data/MOCproxy_for_figshare_v1.0.mat |
Adds the FW2015 v1.0 MATLAB source file to the repo’s local data cache. |
docs/source/reports/fw2015_report.rst |
Updates FW2015 report’s weblink/source file/source URL to Zenodo/v1.0 filename. |
docs/source/reports/rapid_report.rst |
Updates rendered variable statistics (incl. signed-zero output). |
docs/source/reports/mocha_report.rst |
Regenerated report content; variable descriptions now render as “No description available”. |
docs/source/reports/dso_report.rst |
Updates the History timestamp in the generated report. |
docs/source/_static/reports/OSNAP_MOC_MHT_MFT_TimeSeries_201408_202207_2025_timeseries.png |
Updates a static report figure (binary). |
docs/source/_static/reports/FW2015_timeseries.png |
Adds/updates FW2015 static report figure (binary). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| weblink: "https://zenodo.org/records/18606051" | ||
| comment: > | ||
| Dataset accessed and processed via http://github.com/AMOCcommunity/amocatlas | ||
| citation: > |
There was a problem hiding this comment.
citation: > is now an empty block scalar (no indented content). This parses as an empty string and effectively drops the dataset-level citation from metadata. Either restore the citation text here or remove the citation key entirely and rely on the per-file citation below (but avoid leaving an empty > block).
| citation: > | |
| citation: > | |
| Frajka-Williams, E. (2015), Estimating the Atlantic overturning at 26°N using satellite altimetry and cable measurements. Geophys. Res. Lett., 42, 3458–3464. doi: 10.1002/2015GL063220. |
| - -0.00 | ||
| - -0.00 |
There was a problem hiding this comment.
The V_net min/max values are rendered as -0.00, which is confusing in published docs. Consider normalizing “negative zero” to 0.00 in the report generation (or manually fix these rendered values) so the table doesn’t show signed zeros.
| - -0.00 | |
| - -0.00 | |
| - 0.00 | |
| - 0.00 |
| * - *Q_sum* → **MHT** | ||
| - Net meridional heat transport | ||
| - No description available | ||
| - PW | ||
| - (12202,) | ||
| - -0.64 | ||
| - 2.52 | ||
| - 0.0% | ||
| * - *Q_ek* → **MHT_EKMAN** | ||
| - Ekman heat transports | ||
| - No description available |
There was a problem hiding this comment.
These per-variable descriptions were replaced with “No description available”, but the MOCHA metadata YAML includes descriptions for these variables (e.g. original_variable_metadata.Q_sum.description). This looks like an unintended regression in the generated report output; please regenerate/fix the report so it preserves the available variable descriptions (or revert these doc-only changes if unrelated to this PR).
| # Default file list | ||
| FW2015_DEFAULT_FILES = [ | ||
| "MOCproxy_for_figshare_v1.mat", | ||
| "MOCproxy_for_figshare_v1.0.mat", | ||
| ] | ||
| FW2015_TRANSPORT_FILES = ["MOCproxy_for_figshare_v1.mat"] | ||
| FW2015_TRANSPORT_FILES = ["MOCproxy_for_figshare_v1.0.mat"] |
There was a problem hiding this comment.
FW2015 now defaults to MOCproxy_for_figshare_v1.0.mat, but there are still repo docs referencing the old filename MOCproxy_for_figshare_v1.mat (e.g. the FW2015 original format docs and variables reference tables). To avoid broken/incorrect documentation, update those references (or keep backward compatibility by allowing both filenames).
Couldn't download fw2015 using AMOCatlas because figshare was blocking.
Moved the data to zenodo.