[UPDATE] Updated FBC transport with new location and extended timeseries#133
Merged
Merged
Conversation
added 2 commits
April 29, 2026 13:51
Location of the FBC transport file changed to: https://zenodo.org/records/19554222 Updated `fbc.py` to access the new dataset, adjusted `fbc.yml` to account for new variable naming and contributors and changed `test_fbc.py` to test the right file.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Faroe Bank Channel (FBC) transport reader and metadata to use the new Zenodo-hosted NetCDF dataset (1995–2024) referenced in issue #130.
Changes:
- Switched FBC transport loading from the legacy
.txtsource to the new.ncfile on Zenodo. - Updated
fbc.ymlmetadata (project/weblink, time coverage end date, variable mapping). - Updated tests to validate the new default filename and file extension.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
amocatlas/data_sources/fbc.py |
Updates default source/filename and uses ReaderUtils.safe_load_dataset for NetCDF loading. |
amocatlas/metadata/fbc.yml |
Points metadata to Zenodo record and updates time coverage + variable mapping for new dataset. |
tests/test_fbc.py |
Adjusts expectations from .txt to .nc and updates default filename checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Location of the FBC transport file changed to: https://zenodo.org/records/19554222 !!
There, the new updated timeseries is stored which provides FBC transport from 1995-2024.
Changes:
fbc.pyto access new dataset location and changed loading style as file is now no longer.txtbut.nc.fbc.ymlto account for new variable naming and contributors/metadatatest_fbc.pyto test the right file.Related Issues / Pull Requests: