feat: wire presets from settings into CLI wizard#54
Conversation
|
Thanks for being proactive with 29 @Chirag04-bit, preset prompts in the wizard is the right idea, but this PR can't merge as-is for a plethora of reasons. Main issue: scope. #29 is a small addition to the existing CLI, not a rewrite. This PR deletes ~315 lines from What we need instead (same PR is fine after redo):
Rule of thumb for this repo: additive patches on Friendly tip: also please try to work on assigned issues, or ask and wait for assignments before taking initiative. Since Rooms and Skillware are relatively new and under development projects, there are a lot of ripple effects and things might radically change from one commit to another. For that reason, we encourage to ask for issues and only commit to them once you are appointed. Of course, everyone is welcome to open PRs, but you have to do so, only if you are 100% confident in your build and direction, or if you have created the issue yourself, thus you are familiar with what's involved. |
cf65147 to
d3514b1
Compare
|
Hi @rosspeil, thank you for the feedback! I have updated the PR to address your points: Rebased: The branch has been rebased onto the latest main to ensure a clean, additive patch. Additive Focus: I have ensured no core CLI functions (like main, config init/reset, or preflight) were removed. Documentation: Added explanatory comments to rooms.settings.example.yaml and ensured the preset logic is documented. Stability: Resolved Pylance/Type-checking errors to ensure a clean build. Testing: Verified that the full test suite (34 tests) passes as expected. I believe this is now ready for your final review. Thank you for your guidance! |
|
Big improvement on the direction @Chirag04-bit thanks for restoring A few items before merge:
Happy to merge after those, no need to rewrite the file again. <3 |
Problem Statement
Closes #29
Currently,
rooms.settings.yamlsupports apresetsmap containing profiles likelocal-ollamaandopenai. However, the interactive CLI custom-agent wizard and orchestrator configuration setup did not present these options to users, requiring manual entry of LiteLLM model string values every session.Proposed Solution
api_key_env) are resolved inline, using the existing wizard prompts to cleanly guide the user through capturing the environment variable.tests/test_cli_presets.pyto completely cover multi-step CLI interactive paths, mock target layouts, and enforce complete runtime safety.