Skip to content

Start here: one task each, and the eight PRs nobody can merge #354

Open

Description

@ARSH871-bot

Submission is done. I have run a full product audit against main and started on what it found. This issue is so that whoever pulls next has one clear task waiting, and so nobody has to read eight pull requests to work out where we are.

Read this first, pick your one task, ignore the rest.


What the audit found, in four lines

  1. The first screen showed six findings nobody measured — including PC-000 status="none", a fabricated green tick. Fixed in The first screen showed six findings nobody measured #352.
  2. On a network that is not ours, we found 3 things instead of 12. Half fixed in access_control reads the user's policy (#87, half two) #353; the other half is US-26 — Make routing read my policy #319.
  3. Nothing persists. A scan is gone when you restart.
  4. A stranger cannot install this without eight README steps. US-41: docker compose up, and the code change that makes it possible #350 fixes it.

Everything else was in better shape than I expected: two TODO markers in 11,197 lines of product code, no external URLs anywhere in the frontend, and a test suite that mutation-testing shows can actually fail.


Your one task

Pick yours, comment on the issue to say you have started, and ignore everything else in this list. None of these blocks anybody else, which is the point — each sits inside a vertical you already own and touches no file anyone else is currently changing.

@patelankeet2 — #320, the ASA vendor and the support table

I rescoped this before you start, because the original asked for work you had already done. Three vendors already run the full pipeline end to end; vendor-asa is the one that does not, and nothing a user reads says which vendors work at all.

Does not touch: web/, analysis/policy.py, analysis/checks/access_control.py.

@shubhamkataria2005 — #322, does my own policy contradict itself

Pure logic over the policy file. No Batfish, no Docker, no Ollama — the only story in the milestone you can build and test on a laptop with nothing running. It sits on the check you already own.

Does not touch: web/, analysis/checks/access_control.py, tools/.

@SamikaPerera — #347, make the first five minutes work

Reassigned to you, and it pairs directly with #352. I removed the fabricated demo findings, which means a new user now opens the dashboard to an empty state. That is honest, and it is worse to look at.

The honest replacement is a bundled sample the user clicks — invented data is fine when someone chose to see it. That is your slice: the empty state, the sample, and the error states.

Does not touch: analysis/, tools/.

Arsh — #319, routing reads the user's policy

The other half of #87. I am keeping this one because it is on the critical path, and a critical-path item assigned to someone who is not currently active is a blocked product, not a shared workload.


The one thing that genuinely does block me, and a proposal

There are eight open pull requests from me and none of them can merge, because M-1 requires a current approving review from someone who did not write it. That rule is right and I am not asking to weaken it.

But eight is not a queue, it is a wall, and it grows every day I keep working.

Proposal, needs a decision rather than agreement-by-silence: when a pull request has been open with green CI and an unactioned review request for five calendar days, the author may merge it, provided they post a self-review comment naming what they would have wanted a reviewer to look at hardest. The review request stays open and any objection afterwards is handled as a follow-up fix, not a revert.

This is a worse outcome than a real review. It is a better outcome than a fortnight of work that nobody can build on. If you would rather it stayed strict, say so and I will keep stacking — but then I need reviews, not silence.

If you only do one thing: #352 and #353 are the two that matter. #352 is a fabricated green tick on the first screen; #353 is two thirds of the detection that goes missing on a real network.


When you pull

git checkout main && git pull
python -m pytest tests/ -q          # expect 1413 passed, 8 skipped
python -m tools.preflight           # is your machine set up

The audit itself is /audit in .claude/commands/audit.md if you want to run it yourself — it is deliberately hostile and scores the capstone and the product separately, because work that scores well for markers is often worth nothing to a buyer.

Activity

  1. SamikaPerera commented on Sep 14, 2026

    @SamikaPerera
    Collaborator

    Starting now -- taking #347 (US-56, first five minutes). Confirming here since I'm assigned but the issue body still lists Arsh.

  2. shubhamkataria2005 commented on Oct 12, 2026

    @shubhamkataria2005
    Collaborator

    Taken #322 and it is up as #387.

    Pure logic over the policy file, as scoped — no Batfish, Docker or Ollama, and it touches none of web/, analysis/checks/access_control.py or tools/.

    The part worth a reviewer'''s attention is that a comparison has three answers rather than two. Batfish header specifiers are a language (0.0.0.0/0 \ (10.20.0.5), !tcp), so the module parses a deliberate subset and reports what it could not decide instead of guessing. docs/examples/policy.example.json exercises that path: it loads and names two pairs it could not compare, rather than a clean bill of health it has not earned.

    Also reviewed and approved #381 and #386 while I was in here. On #381 I flagged a one-day date error that is mine as much as Samika'''s — I worked out in September that this file dates by UTC, offered to write that down, and never did, so a month later the next person reached for local time exactly as predicted. I will add the missing basis line when I sign my own A-4 row, once #381 lands.

    On your five-day proposal: I would rather give you reviews than a rule. Three are done today. If the wall builds up again I would support it, but it should not be needed while anyone is active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions