Skip to content

The dashboard does not show policy rule pairs the contradiction check could not compare #404

Open

Description

@shubhamkataria2005

Found by @ARSH871-bot reviewing #387. Opening it so #387's docs can point here instead of overclaiming.

The gap

#387 adds Policy.undecidable: pairs of policy rules that might contradict each other but use header syntax the contradiction check does not parse (0.0.0.0/0 \ (…), !tcp, or a filter name Batfish may resolve to the same ACL). The design rule is that such a pair is said, never dropped, because "we could not compare these" must not read as "these are fine".

Today that holds on the command line only:

surface shows undecidable pairs
python -m analysis.pipeline … --policy yes, as warning: lines
python -m analysis.change_impact … policy.json yes (#387)
/api/policy upload response no — returns renamed only (web/main.py:2022)
dashboard policy pane no

Uploading docs/examples/policy.example.json through the dashboard returns 200 with no mention of the pair it could not compare.

What would close it

/api/policy returns undecidable beside renamed (and assigned, which also is not returned), and the policy pane renders each as a warning, in the existing "heads-up, not a second success sentence" style. Plus one test that uploads the example and asserts the warning is in the response.

Ownership

web/ is @SamikaPerera's, and #354 kept me out of it, so I am not assigning myself. Happy to write the backend half (/api/policy returning the list) if that is easier, and leave the rendering to whoever owns the pane.

Activity

  1. added a commit that references this issue on Oct 18, 2026
  2. SamikaPerera commented on Oct 27, 2026

    @SamikaPerera
    Collaborator

    Thanks for asking before taking it. I'm fine with that split: you take the backend half, and I do the web/ rendering.

    From the issue, the backend half is /api/policy returning undecidable beside renamed, and also assigned, which the issue says isn't returned today. I had Claude Code check web/main.py:2022, and it returns renamed only. The web/ half is rendering each one in the policy pane as a warning in the existing "heads-up" style, plus the test the issue asks for: upload docs/examples/policy.example.json and assert the warning is in the response.

    One dependency: Policy.undecidable isn't on main yet. I had Claude Code grep analysis/policy.py at dc93ccb and it isn't there, so the backend half waits on #387. assigned does exist (analysis/policy.py:233).

    I haven't scheduled the rendering half yet, so I can't give a date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions