You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Finding subject (A-3 key set): close D1-D4 and finish the ratification #438
#390 merged with the key-set table at two of four. These are cheap to fix while nothing populates subject yet.
D1: pin the unknown-key check. Use pytest.raises(ValueError, match="unknown key"), add {"dest": "tcp"}, and make the branch elif key == "protocol": with else: raise.
D2: refuse any address containing % (an IPv6 zone ID) in _canonical_address, with a test.
D3: drop the count from the status note. The table is the record.
D4: give A-3's original signature table its own heading, or move the key-set section below it.
Yes from me on the key set: src, dst, srcPort, dstPort, protocol, as in the table at docs/finding-format.md:371-375 and SUBJECT_KEYS at analysis/findings.py:133. When the PR for this issue is open, please tick my row in it, or tell me where to do it.
I had Claude Code check that nothing in web/ or risk.py reads or writes a subject key today.
One thing for later: _F1_FIELDS at web/main.py:1823 would drop subject from saved scans. That is in web/, which is mine, so I'll deal with it when something starts filling subject.
I'm glad D2 is on the list. subject goes into the model prompt. In my injection test on 1 Nov, text from ACL names and similar fields did not make the model obey it, but that is one test, so a closed set is the safer shape.
Activity
SamikaPerera commentedon Nov 3, 2026
Yes from me on the key set: src, dst, srcPort, dstPort, protocol, as in the table at docs/finding-format.md:371-375 and SUBJECT_KEYS at analysis/findings.py:133. When the PR for this issue is open, please tick my row in it, or tell me where to do it.
I had Claude Code check that nothing in web/ or risk.py reads or writes a subject key today.
One thing for later: _F1_FIELDS at web/main.py:1823 would drop subject from saved scans. That is in web/, which is mine, so I'll deal with it when something starts filling subject.
I'm glad D2 is on the list. subject goes into the model prompt. In my injection test on 1 Nov, text from ACL names and similar fields did not make the model obey it, but that is one test, so a closed set is the safer shape.
Tick Samika's row in the A-3 key-set table (#438)