You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Routing computed fact blames routing for filter denials and missing devices (#399 follow-up) #439
The flat branches at ai/explain.py:424-425 and :442-443 say "the network's current routing is what disagrees" for every disposition. DENIED_IN and DENIED_OUT are filters, not routing. EXITS_NETWORK is, per routing.py:34-41, most often a device missing from the upload. The model is told this fact is "already verified", and tests/test_explain_safety_net.py:441 pins the wording for a NO_ROUTE + DENIED_IN case.
Producer drift: tests/test_explain_safety_net.py:370 still hand-writes the "Expected … for a flow from" prefix, copied from routing.py:485-486. Build the detail through routing.run() with a fake Session instead.
The mixed-result text says "(one ended in X)" even when more than one path failed (:414).
Suggested fix: state the observed disposition without a cause, or say "left the part of the network that was uploaded" for EXITS_NETWORK. Measured on 94bc75c, before the merge: routing was blamed in 8 of 8 runs on both shapes. The blame wording is unchanged at the merged head.
Activity
Merge pull request #460 from ARSH871-bot/fix/439-routing-fact-cause-a…