Skip to content

Pin both sides of the relative-folder fix, and the CLI's own spelling (#463 follow-up) - #477

Open
shubhamkataria2005 wants to merge 1 commit into
mainfrom
test/463-relative-folder-gaps
Open

shubhamkataria2005 wants to merge 1 commit into
mainfrom
test/463-relative-folder-gaps

Conversation

@shubhamkataria2005

Copy link
Copy Markdown
Collaborator

Tests only. These are @ARSH871-bot's two tests from his review of #463 ("take or leave"), held back so they wouldn't void that PR's approvals. Now that #463 is merged, they land on their own.

His mutation run on #463 found two gaps the merged tests can't see:

  • Only the before folder resolved. "." proves the before side alone. A relative after-folder named after would rewrite the word "after" in a card.
  • Resolved even without labels. The command line would show a full path instead of the folder the user typed.

Each test fails against its mutant (2 of 2) and passes on main. tests/test_change_impact_no_paths.py: 13 passed. Full suite: see CI. ruff clean.

Arsh's two tests from his #463 review, held back so they would not void
that PR's approvals. Mutation there showed two gaps the merged tests do not
see: resolving only the before folder (a relative 'after' folder would
rewrite the word 'after' in a card), and resolving even without labels (the
command line would show a full path instead of the folder as typed). Each
test fails against its mutant.

@ARSH871-bot ARSH871-bot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13fa10f, merged onto main cceffec. Approving.

These are my two tests from #463, unchanged apart from the docstrings, so I checked them again on today's main rather than taking my own earlier run on trust:

  • Both pass, and the CI-style suite on the merge is 2455 passed, 63 skipped (2 more than main). Ruff clean.
  • Each still fails against the mutant it was written for: resolving only the before folder fails the first, resolving even without labels fails the second. main's copy of the file passes both mutants, so these two are the only tests watching those lines.

Thanks for landing them separately so #463's approvals stood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants