Repository navigation
Pin both sides of the relative-folder fix, and the CLI's own spelling (#463 follow-up) - #477
Open
shubhamkataria2005 wants to merge 1 commit into
Open
shubhamkataria2005 wants to merge 1 commit into
shubhamkataria2005 wants to merge 1 commit into
Conversation
Arsh's two tests from his #463 review, held back so they would not void that PR's approvals. Mutation there showed two gaps the merged tests do not see: resolving only the before folder (a relative 'after' folder would rewrite the word 'after' in a card), and resolving even without labels (the command line would show a full path instead of the folder as typed). Each test fails against its mutant.
ARSH871-bot
approved these changes
Nov 19, 2026
ARSH871-bot
left a comment
Owner
There was a problem hiding this comment.
Reviewed 13fa10f, merged onto main cceffec. Approving.
These are my two tests from #463, unchanged apart from the docstrings, so I checked them again on today's main rather than taking my own earlier run on trust:
- Both pass, and the CI-style suite on the merge is 2455 passed, 63 skipped (2 more than
main). Ruff clean. - Each still fails against the mutant it was written for: resolving only the before folder fails the first, resolving even without labels fails the second.
main's copy of the file passes both mutants, so these two are the only tests watching those lines.
Thanks for landing them separately so #463's approvals stood.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only. These are @ARSH871-bot's two tests from his review of #463 ("take or leave"), held back so they wouldn't void that PR's approvals. Now that #463 is merged, they land on their own.
His mutation run on #463 found two gaps the merged tests can't see:
"."proves the before side alone. A relative after-folder namedafterwould rewrite the word "after" in a card.Each test fails against its mutant (2 of 2) and passes on
main.tests/test_change_impact_no_paths.py: 13 passed. Full suite: see CI. ruff clean.