Repository navigation
[52] support "variantKey" parameter in withToggledHookFactory, mirroring withTogglePointFactory - #53
Merged
asos-dominicjomaa merged 19 commits intoSep 30, 2025
Conversation
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
add content management example fixup webpackNormalModule fixup package.json for next example consistent README/specs
TomStrepsil
changed the title
… of github.com:TomStrepsil/web-toggle-point into bug/52-support-variantKey-in-with-toggled-hook-factory
TomStrepsil
changed the title
asos-dominicjomaa
approved these changes
Sep 30, 2025
TomStrepsil
deleted the
bug/52-support-variantKey-in-with-toggled-hook-factory
branch
October 21, 2025 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
resolves #52
Details
variantKeyoption forwithToggledHookFactory, aligning with change made towithTogglePointFactoryin version 0.4.0 of thereact-pointcutspackage.withToggledHookScout Rule
webpackNormalModuleoption of thewebpackpackage to just take a module, rather than an async function - born out of a mistake when importing originally, I assume.toggle-point.d.tsfromtsconfig.jsonin NextJs examplewithTogglePointFactoryREADME.md, this doesn't make sense for a monorepo that doesn't git-tag releasesCheckList
main.