Skip to content

Implement milestone-based release schedules in escrow contract #299

Closed

Description

@Cjay-Cyber-2

Description — what to implement and the why/impact.

The escrow contract (contracts/escrow) currently supports simple lock-and-release mechanics. This task adds support for milestone-based fund releases, allowing partial withdrawals as discrete project milestones are validated and approved.

Context & Requirements — background, constraints, design references, edge cases; grounded in the actual repo (real files, stack, conventions).

  • Workspace member: contracts/escrow
  • Soroban SDK: soroban-sdk = "21.7.7"
  • Partial release amounts must sum up correctly without leaving dust or over-releasing funds.
  • Edge cases: Releasing funds for invalid milestone indices and duplicate milestone approvals.

Acceptance Criteria — a checklist ("- [ ] ...") of specific, testable conditions that define "done".

  • Define milestone struct and storage schema in contracts/escrow/src/storage.rs.
  • Implement milestone submission and approval functions in contracts/escrow/src/lib.rs.
  • Add unit tests verifying partial fund disbursements per milestone.

Implementation Guidance — likely files/modules to touch (use real paths from the repo context) and a suggested approach, without over-prescribing.

  • Modify contracts/escrow/src/lib.rs and contracts/escrow/src/storage.rs.

Testing & Validation — how the contributor should prove it works (tests to add/run, manual checks, screenshots for UI).

  • Run cargo test --package astroid-escrow to validate escrow behavior.

Submission Guidelines — must open a PR that includes "Closes #"; assignment is required before starting; follow the repo's existing style and conventions.


Wave complexity: Medium

Activity

  1. Oluwaferanmi18 commented on Sep 25, 2026

    @Oluwaferanmi18
    Contributor

    @Oluwaferanmi18 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I would like to work on this issue and contribute a simple, reliable fix.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oluwaferanmi18 to this issue.

  2. drips-wave commented on Sep 25, 2026

    @drips-wave

    Congratulations, @Oluwaferanmi18! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @Oluwaferanmi18: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  3. added a commit that references this issue on Oct 7, 2026
    483f28e
  4. drips-wave commented on Oct 7, 2026

    @drips-wave

    This issue has been marked as completed by a Drips Wave moderator for @Oluwaferanmi18 as part of the Stellar Wave Program's 9th Wave 🥳

    Moderator's reason: [Auto-assessed] Pull request #362 was merged by maintainer Cjay-Cyber-2 on 2026-10-07, successfully closing issue #299.

    😎 @Oluwaferanmi18: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

    ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions