Skip to content

feat(registry): validate implementation versions before registration (#337) - #358

Merged
Cjay-Cyber-2 merged 11 commits into
ASTROIDX556:mainfrom
Ayfataan:feat/registry-upgrade-validation
Oct 5, 2026
Merged

Cjay-Cyber-2 merged 11 commits into
ASTROIDX556:mainfrom
Ayfataan:feat/registry-upgrade-validation

Conversation

@Ayfataan

Copy link
Copy Markdown
Contributor

Summary

  • Add a runtime interface-version entrypoint to the shared upgradeable interface and implement it across all eight contracts.
  • Validate the target contract reports the current interface version before storing a version mapping; unsupported or unavailable targets fail with InvalidInput.
  • Reject duplicate (kind, version) registrations with AlreadyExists and non-increasing versions with InvalidInput; registry admin authorization remains required.
  • Add registry tests for compatible registration, incompatible targets, duplicate versions, and downgrades, plus runtime interface-compliance coverage.

Validation

  • cargo test --package astroid-registry could not run because cargo is not installed or available on PATH.
  • git diff --check passed.

Closes #337

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@Ayfataan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure
  • fmt: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure
  • fmt: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure
  • fmt: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure
  • fmt: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

1 similar comment
@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure
  • fmt: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure
  • fmt: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

Merge Conflict — Action Needed

This pull request has merge conflicts with the base branch (main).

What to do: update your branch by merging or rebasing against main, resolve any conflicts locally, and push the result.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • build: failure
  • clippy: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

CI Checks Failed — Action Needed

The continuous integration checks on this pull request are failing. I can't merge until all required checks pass.

Failing checks:

  • clippy: failure
  • build: failure

What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes.

@Cjay-Cyber-2
Cjay-Cyber-2 merged commit be9280b into ASTROIDX556:main Oct 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add version upgrade validation hook in astroid-registry contract

2 participants