Repository navigation
feat(wallet): implement wallet resource methods - #363
Merged
Cjay-Cyber-2 merged 1 commit intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
packages/wallet/src/index.ts: AddedgetWallet,listWallets,getWalletBalances, andfundWalletresource methods using the shared client helpers, with optional request options, typed parameters, and TSDoc usage examples.packages/types/src/dto.ts: AddedWalletBalanceQueryandFundWalletInput, with exact decimal-string amounts and typed Stellar asset/issuer fields; used the public-key type for imported wallet addresses.packages/types/src/entities.ts: AddedStellarAssetCodeandStellarPublicKeyaliases and applied them to wallet and balance DTO fields while retaining balance amounts asDecimalString.packages/wallet/__tests__/wallet.test.ts: Added mocked-client tests for each requested method, including route/query handling and preservation of decimal amounts as strings.Why
Expose the wallet collection and balance/funding endpoints through the SDK's typed
WalletResourceAPI, while preventing monetary precision loss and clarifying Stellar asset and issuer fields.How it Was Tested
pnpm --filter @astroid/wallet test: passed, 53 tests across 7 files. New cases cover fetching, listing, balance filters, and funding request payloads with exact decimal strings.pnpm --filter @astroid/wallet typecheck: passed.pnpm typecheck: currently fails in the fetched upstream baseline atpackages/agent/src/__tests__/validation.test.ts, which imports missingCreateAgentDtoSchemaandUpdateAgentDtoSchemaexports from@astroid/types. This failure is unrelated to the wallet changes.Closes #275