Repository navigation
Fix Python CI install failure and bump deprecated actions - #89
Merged
Merged
Conversation
…tions
The merged CI run failed in every Python job at the install step because
hatchling rejects a readme path outside the package directory
("Readme path must be within the project directory: ../README.md").
Add python/README.md, point pyproject.toml at it, and list it in the
repository tree.
Bump actions/checkout to v5 and actions/setup-python to v6, which the
same run flagged as Node 20 deprecated, and give the pip cache an
explicit dependency path.
Verified with the exact CI commands: pip install -e "./python[test]"
succeeds and python -m pytest python/tests passes 78 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #88. The first CI run on
mainafter the merge failed in all three Python jobs (3.10, 3.11, 3.12) at the install step; the C++ and MATLAB jobs passed.Cause
hatchling refuses a readme path outside the package directory:
Fix
python/README.md(short package README that points to the repository README) and reference it frompyproject.toml.actions/checkoutto v5 andactions/setup-pythonto v6, which the same run flagged as Node 20 deprecated, and give the pip cache an explicit dependency path.Verification
Run with the exact CI commands from the repository root:
python -m pip install -e "./python[test]"Successfully installed ion-propulsion-1.2.0python -m pytest python/testspip show ion-propulsionGenerated by Claude Code