Add instructions on input data format#108
Open
RunzeZhang123 wants to merge 3 commits intoAUTODIAL:mainfrom
Open
Add instructions on input data format#108RunzeZhang123 wants to merge 3 commits intoAUTODIAL:mainfrom
RunzeZhang123 wants to merge 3 commits intoAUTODIAL:mainfrom
Conversation
Collaborator
|
Hi @RunzeZhang123, here's what I think should be addressed in this PR:
Preferably all in a single markdown file. Feel free to add more items if I missed anything. |
ma-sadeghi
requested changes
Apr 19, 2024
Collaborator
ma-sadeghi
left a comment
There was a problem hiding this comment.
Nice work. Here are the things that would make the document more manageable:
- Make it a proper ipynb file, and the code snippet a proper python code cell
- Download 3 sample datasets from pyimpspec tests folder and actually load the data and visualize using autoeis to show users how to work with real data (data coming from real EIS devices)
- Dump the toy datasets into AutoEIS/src/assets and access it via utils.get_assets_folder()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placeholder to add better instructions on the input data formatting.