New functions for posterior evaluation#142
Open
Wenda-Lou wants to merge 1 commit intoAUTODIAL:mainfrom
Open
Conversation
These 2 files are used as helper functions for evaluating the posterior distribution of ECM and EIS data. The "evaluate_posterior_distribution" defines functions that scores MCMC posterior distributions of each component in the ECM. It gives a functionality score for each component based on R^2 from a QQ-plot to a normal distribution, skewness of the sample and the number of peaks appeared on the distribution. The script "update_circuits_info" complements "evaluate_posterior_distribution" by applying the posterior quality evaluation to a list of AutoEIS inference results and updating a circuits_df DataFrame accordingly.
Collaborator
|
Hi @Wenda-Lou, thanks for the PR! You can find my comments under "Files changed". I'm still trying understand the PR better. I'll give it a try tonight or tomorrow and will get back to you. |
Author
|
Thank you for your feedback. I developed this module alongside Zhecheng Yin, another undergraduate student. He should have started a separate PR outlining the basic workflow of this module. It might be easier to review the code in conjunction with the workflow outlined in his PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two helper modules for evaluating the quality of MCMC posterior distributions from ECM (Equivalent Circuit Model) fits and integrating those evaluations into the AutoEIS pipeline.
New Modules
1. evaluate_posterior_distribution.py
2. update_circuits_info.py
These tools enhance AutoEIS by: