Rework chunk-based replacer to work with less collision-prone pattern matching - #48
Open
Black-Platypus wants to merge 1 commit into
Open
Rework chunk-based replacer to work with less collision-prone pattern matching#48Black-Platypus wants to merge 1 commit into
Black-Platypus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "chunk" based replacer trips up on false positives:
Imagine a LoRA has two underscores. The wildcard replacer splits up the text, gets a nonsense chunk, can't find a matching wildcard file, returns "the original text". Doesn't sound so bad, but the LoRA will now fail to load because it's missing the two underscores.
To prevent this and further complications, depending on other features, I've switched to a RegEx based approach that should more closely capture syntax representing intent to replace wildcards.
\b__([^\s\r\n]+?)__\b