Skip to content

Add AVEVA ruleset minimum configuration - #27

Closed
quasarea wants to merge 1 commit into
mainfrom
feature/4728594-rulesetminimum
Closed

Add AVEVA ruleset minimum configuration#27
quasarea wants to merge 1 commit into
mainfrom
feature/4728594-rulesetminimum

Conversation

@quasarea

Copy link
Copy Markdown
Collaborator

What changed

  • add central package management for Aveva.RulesetMinimum and Microsoft.CodeAnalysis.NetAnalyzers
  • add a repo-wide Directory.Build.props to apply the ruleset package to C# projects
  • copy the packaged Aveva.RulesetMinimum .editorconfig into the repo root

Why changed

  • align the repository with the AVEVA minimum analyzer/ruleset baseline
  • keep analyzer configuration sourced from the shipped package content

Traceability

  • Work item: 4728594

Validation

  • focused file validation in the local workspace for Directory.Build.props, Directory.Packages.props, and .editorconfig
  • GitHub Actions PR validation pending

@quasarea

Copy link
Copy Markdown
Collaborator Author

PR Readiness Scorecard

  • Traceability: 8.0/10
    • Work item referenced: 4728594
  • Scope clarity: 8.5/10
    • Change is limited to ruleset/analyzer onboarding files
  • Validation: 5.0/10
    • Local focused validation completed
    • GitHub Actions PR validation pending
  • Risk: 7.5/10
    • Repo-wide analyzer onboarding may surface follow-up warnings in consumer environments
  • Usefulness review: Keep
    • Keep the central package and build props onboarding
    • Keep the packaged root .editorconfig copy
    • Cut nothing at this stage unless CI shows a compatibility issue

Overall: 7.3/10
Status: pending CI

@quasarea

Copy link
Copy Markdown
Collaborator Author

PR Readiness Scorecard Update

  • Traceability: 8.0/10
    • Work item referenced: 4728594
  • Scope clarity: 8.5/10
    • Change remains limited to ruleset/analyzer onboarding files
  • Validation: 9.0/10
  • Risk: 7.5/10
    • Repo-wide analyzer onboarding may still surface downstream warning cleanup later
  • Usefulness review: Keep
    • Keep the central package and build props onboarding
    • Keep the packaged root .editorconfig copy
    • Cut nothing from the submitted scope

Overall: 8.3/10
Status: green

@quasarea

Copy link
Copy Markdown
Collaborator Author

Closing this PR because the change belongs in the internal Azure DevOps repository, not the public mirror.

@quasarea quasarea closed this Apr 30, 2026
@quasarea
quasarea deleted the feature/4728594-rulesetminimum branch April 30, 2026 13:17
@quasarea quasarea added the invalid This doesn't seem right label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant