ci(release): drop the broken, redundant docs job - #42
Merged
Conversation
The release workflow's update-docs job deployed `./docs/build`, but the docs are Astro and build to `docs/dist` — so it failed with ENOENT on every tag. It also duplicated docs.yml, which already deploys Pages correctly (path: docs/dist, official Pages flow) on docs/** pushes. Remove the job rather than fix it; docs.yml is the single source of truth for the docs site. Claude-Session: https://claude.ai/code/session_01M4Dd5oASBGHwr6ts6wTnYn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
update-docsjob fromrelease.yml.Why
It failed on every tag (incl. the v0.2.0 release) with
ENOENT: docs/build: it deployedpublish_dir: ./docs/build, but the docs are Astro, which builds todocs/dist. It was also redundant —docs.ymlalready deploys the docs to GitHub Pages correctly (path: docs/dist, officialconfigure-pages/upload-pages-artifact/deploy-pagesflow) ondocs/**pushes.Rather than fix the path on a duplicate job, removed it so
docs.ymlis the single source of truth for the docs site.release.ymlnow does exactly what it should: GitHub Release, binaries, and the signed Docker image.https://claude.ai/code/session_01M4Dd5oASBGHwr6ts6wTnYn