Skip to content

Sdk 4971 updated#5

Open
AakashHotchandani wants to merge 11 commits into
mainfrom
SDK-4971-updated
Open

Sdk 4971 updated#5
AakashHotchandani wants to merge 11 commits into
mainfrom
SDK-4971-updated

Conversation

@AakashHotchandani

Copy link
Copy Markdown
Owner

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new

pkg-pr-new Bot commented Jan 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/create-wdio@5

eslint-plugin-wdio

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/eslint-plugin-wdio@5

@wdio/allure-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/allure-reporter@5

@wdio/appium-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/appium-service@5

@wdio/browser-runner

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/browser-runner@5

@wdio/browserstack-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/browserstack-service@5

@wdio/cli

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/cli@5

@wdio/concise-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/concise-reporter@5

@wdio/config

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/config@5

@wdio/cucumber-framework

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/cucumber-framework@5

@wdio/dot-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/dot-reporter@5

@wdio/firefox-profile-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/firefox-profile-service@5

@wdio/globals

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/globals@5

@wdio/jasmine-framework

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/jasmine-framework@5

@wdio/json-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/json-reporter@5

@wdio/junit-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/junit-reporter@5

@wdio/lighthouse-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/lighthouse-service@5

@wdio/local-runner

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/local-runner@5

@wdio/logger

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/logger@5

@wdio/mocha-framework

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/mocha-framework@5

@wdio/protocols

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/protocols@5

@wdio/repl

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/repl@5

@wdio/reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/reporter@5

@wdio/runner

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/runner@5

@wdio/sauce-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/sauce-service@5

@wdio/shared-store-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/shared-store-service@5

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/smoke-test-cjs-service@5

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/smoke-test-reporter@5

@wdio/smoke-test-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/smoke-test-service@5

@wdio/spec-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/spec-reporter@5

@wdio/static-server-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/static-server-service@5

@wdio/sumologic-reporter

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/sumologic-reporter@5

@wdio/testingbot-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/testingbot-service@5

@wdio/types

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/types@5

@wdio/utils

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/utils@5

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/webdriver-mock-service@5

@wdio/xvfb

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/@wdio/xvfb@5

webdriver

npm i https://pkg.pr.new/AakashHotchandani/webdriverio/webdriver@5

webdriverio

npm i https://pkg.pr.new/AakashHotchandani/webdriverio@5

commit: 493d26b

Removed detailed documentation comment for uploadEventsData method.
Removed the SDK_EVENTS_LIST constant that aggregates all SDK events for performance metrics tracking.
BStackLogger.debug(`Successfully uploaded performance events ${util.format(await result.text())}`)
BStackLogger.debug(`[Performance Upload] Successfully uploaded to EDS: ${util.format(await result.text())}`)

this.end(EVENTS.SDK_KEY_METRICS_UPLOAD, true)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start call for this event EVENTS.SDK_KEY_METRICS_UPLOAD is not there?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

353 line its started

BStackLogger.debug('Sending stop launch event')
await (BrowserstackCLI.getInstance().isRunning() ? BrowserstackCLI.getInstance().stop() : stopBuildUpstream())
try {
BStackLogger.debug('Inside OnComplete hook..')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove one of the log lines as they are same

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes

@Tanmay-Bstack
Tanmay-Bstack self-requested a review January 21, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants