Skip to content

[Backport version-15] feat(openimmo): fix apartment type mapping and remove default zimmer fallback #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aakvatech merged 1 commit into from
May 22, 2026
Merged

[Backport version-15] feat(openimmo): fix apartment type mapping and remove default zimmer fallback #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions openimmo_propms/services/xsd_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,18 +116,11 @@ def _format_value(self, val):
def _fill_group(self, node, group, data, prefix):
"""Processes a sequence or choice group."""
if group.model == 'choice':
# Find first branch that has data
selected_branch = None
# Data-Driven selection: Only fill if data exists
for branch in group:
if self._has_data_recursive(branch, data, prefix):
selected_branch = branch
self._fill_item(node, branch, data, prefix)
break

if selected_branch:
self._fill_item(node, selected_branch, data, prefix)
elif group.min_occurs > 0:
# Mandatory choice, no data. Force first branch to maintain structure.
self._fill_item(node, group[0], data, prefix, force_mandatory=True)

else: # sequence or all
for item in group:
Expand Down