Do not use ATOMIC_MOVE option when moving downloaded files

[OlliKiljunen]

JDK Specs:

ATOMIC_MOVE
The move is performed as an atomic file system operation and all other options are ignored. If the target file exists then it is implementation specific if the existing file is replaced or this method fails by throwing an IOException. If the move cannot be performed as an atomic file system operation then AtomicMoveNotSupportedException is thrown. This can arise, for example, when the target location is on a different FileStore and would require that the file be copied, or target location is associated with a different provider to this object.

Reportedly, it throws AtomicMoveNotSupportedException on Juha's Windows machine where temp files are located in a different drive than the project folder.

Anyway, it seems that having both REPLACE_EXISTING and ATOMIC_MOVE options makes no sense as the former is ignored.

[github-actions]

Qodana for JVM

47 new problems were found

Inspection name	Severity	Problems
Unstable API Usage	🔶 Warning	25
Unused import directive	🔶 Warning	8
Long overload to Duration conversion	🔶 Warning	4
Possibly blocking call in non-blocking context	🔶 Warning	1
Unused symbol	🔶 Warning	1
'map' call can be replaced with 'forEach'	◽️ Notice	2
Explicit 'get' or 'set' call	◽️ Notice	2
Not-null assertion can be replaced with 'return'	◽️ Notice	2
Convert try / finally to use() call	◽️ Notice	1
Lambda argument inside parentheses	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions