Repository navigation
Conversation
Owner
|
Thanks for the contribution. We’re keeping Python 3.9 compatibility for now, while urllib3 2.8.0 requires Python 3.10+, so this change can’t be merged in its current form. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
urllib3to address GHSA-8988-9cw3-xx77, GHSA-gh4c-6fx4-qh6g, and GHSA-vxq7-64xx-v4gw.Evidence:
requirements.txtpinnedurllib3==2.6.3urllib3@2.6.3(all fixed in 2.8.0)2.8.0Validation:
requirements.txtandrequirements-web.txtsucceeds withurllib32.8.0python -m pytest -q --ignore=tests/test_gui_layout.py: 290 passed, 1 failedweb/server.py::test_outlook_mailboxes, async test collected without pytest-asyncio) also fails on the unmodifiedmainbranch, so it predates this changepip-audit --requirement requirements.txt --no-depsno longer reports anyurllib3advisorypip-auditstill reports unrelated pins (filelock3.19.1,idna3.13,requests2.32.5) with their own advisories; this patch only clears theurllib3onesScope: requirements.txt one-line pin change only.