Implemented the State Pattern in data_prep.py#115
Open
Benjamin-Pickers wants to merge 1 commit intoAaronWard:masterfrom
Open
Implemented the State Pattern in data_prep.py#115Benjamin-Pickers wants to merge 1 commit intoAaronWard:masterfrom
Benjamin-Pickers wants to merge 1 commit intoAaronWard:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the state pattern to help aid the methods that need to know whether or not a country was specified. There are two states, CountryGivenState and GlobalCountryState, the both implement the State interface. The Country class is the one that should be instantiated and its determines whether a country was given or not. Functions can then be called through the Country class and will be handled according to the state.