Implementing a Proxy class for the GitHub data#83
Open
Benjamin-Pickers wants to merge 2 commits intoAaronWard:masterfrom
Open
Implementing a Proxy class for the GitHub data#83Benjamin-Pickers wants to merge 2 commits intoAaronWard:masterfrom
Benjamin-Pickers wants to merge 2 commits intoAaronWard:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the src folder so that,
github.pynow has a classGithuband implements the interfaceDataInterface. The interface makes theGithubclass implement the functionget(), which is the main function used to get the data. Once wiki.py is implemented, then it can also implement the interface.I then implemented the Proxy pattern by adding a class called
GithubProxywhich acts as a proxy for theGithubclass. This proxy helps separate theGithubobject from the user by forcing them to go through the proxy, thus making it so that they cannot access any unneeded functions and they can not alter the original data.