Bridge Pattern Implemented with views.py and iDataResource.py#85
Open
lariyana wants to merge 12 commits intoAaronWard:masterfrom
Open
Bridge Pattern Implemented with views.py and iDataResource.py#85lariyana wants to merge 12 commits intoAaronWard:masterfrom
lariyana wants to merge 12 commits intoAaronWard:masterfrom
Conversation
github,py and wiki.py scrapes and fetches data for lis_countries and data prep to visualize. Created a new file to aggregate data instead of individually
Created new builder_data_vis.py to implement a Builder Pattern to help separate the construction of the graphs and treadlines in data_visualization,py from its representation. Gives Builder control of parameters to create different representation of the visualization.
Implemented a Bridge Pattern to try and extend the ways graphs can be displayed. created multiple views(concrete) to display multiple types of graphs(concrete) This allows less class building and more cardinality among the bridge pattern classes
Implemented a Bridge Pattern to try and extend the ways graphs can be displayed. created multiple views(concrete) to display multiple types of graphs(concrete) This allows less class building and more cardinality among the bridge pattern classes to view a range of graph types in multiple ways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a Bridge Pattern to try and extend the approach how graphs can be displayed in a various formats.
created multiple views(concrete) to display multiple types of graphs(concrete)
This allows less class building and more cardinality among the bridge pattern classes, which can allow a range of graph types(pie, bar, etc) to be viewed in multiple ways (complete, extended, quick, etc).
This will avoid, having to create multiple individual classes, for example, a single class that has a bar graph with a quick view, and another class for a bar graph with an extended view.
This Bridge Pattern will instead "bridge" each concrete view with each concrete graph type for less class building and more flexibility.