Bridging third party HTML5 charts#97
Open
MuhammedMujahid wants to merge 6 commits intoAaronWard:masterfrom
Open
Bridging third party HTML5 charts#97MuhammedMujahid wants to merge 6 commits intoAaronWard:masterfrom
MuhammedMujahid wants to merge 6 commits intoAaronWard:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adding functionality of viewing forecasts and trends with third party HTML5 charts which are implemented with the bridge design pattern
Why?
To add scalable functionality to the project. This is best done by using bridge pattern since we are bridging chartAPI
How?
By having two seperate seperate hierarchies, one for abstraction and other for implementation.
Testing?
N/A
Screenshots (optional)
N/A
Anything Else?
Pls merge, thx