Conversation
cc611ac to
98f250a
Compare
|
I think this is possibly over engineered, maybe it should just provide a way to serialize itself to a |
|
@Phaiax You've done great work here! Do you think you could please open a separate PR that only provides support for from |
|
Not now, since I am in holiday for another 4 weeks. But then I guess I could.
Am 30. April 2017 10:17:00 GMT+07:00 schrieb Ofek Lev <notifications@github.com>:
…
@Phaiax You've done great work here!
Do you think you could please open a separate PR that only provides
support for from &[u8] and to Vec<u8>? We have great need for such
functionality and a PR with surface that small will get merged very
fast.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#67 (comment)
|
|
That would be fantastic, thanks! |
|
Thank you for the contribution! These are a lot of changes. Could you explain the reasoning behind them?
|
Added Functions:
The iterators for the limbs may not be performant, but
they are only used in write_big_endian_buffer() if the target is a big endian system, and this functionality is untested because I do not have a big endian system and will panic! on big endian.
Lets discuss :)
#6