Skip to content

Redesign the web page: clearer settings, progress, clip list and accessibility - #25

Merged
AbdulSamad94 merged 3 commits into
mainfrom
feat/ui-ux-refresh
Nov 17, 2026
Merged

AbdulSamad94 merged 3 commits into
mainfrom
feat/ui-ux-refresh

Conversation

@AbdulSamad94

@AbdulSamad94 AbdulSamad94 commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

What this changes

A redesign of the web page that keeps the dark-and-yellow look and fixes the usability and accessibility problems. It adds a ⋯ menu, folding for clips and videos, and an uploads tray. Also adds deleting a single clip.

DesktopPhone (390px)
Desktop view Phone view

Settings

  • Clip count, clip length and aspect ratio are one-click button groups (real radio buttons, so arrow keys work).
  • Caption style and framing are restyled dropdowns, and the hook text and pause removal are on/off switches with a one-line explanation.
  • Every field has a visible label. Uploading a file uses a drop box that shows the file's name.
  • Errors put the cursor in the field that caused them.
  • New fonts: Bricolage Grotesque, Instrument Sans and JetBrains Mono. They fall back to Segoe UI when offline.

Progress

  • Making clips shows three named steps (get the video, pick the best moments, cut and caption) with a plain explanation of the current step, and notes when clips are already ready.
  • A YouTube upload shows a box under its clip, waiting → uploading → posted, scheduled or failed, plus an uploads tray in the bottom-right corner that can be minimized. It can't be closed while something is still uploading.

Clips and videos

  • One row per clip: rank, length, score with a word (not color alone), the hook it opens with, why it was picked, and hashtags.
  • Download and Post to YouTube stay on the card. Copy caption, post again, open on YouTube and delete move to a ⋯ menu.
  • Any clip can fold into one line. Posted clips fold by themselves.
  • Each video is a panel showing its source, how long ago it was made, how clips were picked, and Clips / Posted / Best score. Older videos start folded.

Accessibility

  • Visible focus rings, buttons at least 44px tall, a skip link, and headings in order.
  • Labelled progress bars and keyboard support for the menu (arrow keys, Esc returns focus to the button).
  • Screen readers hear only real changes, not every percent tick. Animations stop for users who've switched on reduced motion.

Server: DELETE /api/jobs/{id}/clips/{index} deletes one clip and its files. It's refused while the video is still processing or any of its clips is uploading, because uploads track their clip by position and would end up on the wrong one.

Docs:

  • README: new screenshot, a "Using it" section, and an updated roadmap and limitations (posting to YouTube was listed as missing).
  • docs/youtube-setup.md: how the uploads tray and folding work.
  • CONTRIBUTING: how to contribute UI changes.

Related: #24 (help wanted for further UI/UX work)

How I tested it

  • pytest: 232 pass, including new tests for deleting a single clip, zipping while a clip is deleted, and refusing a post when the clip changed.

  • Rendered the page in headless Chrome with sample finished jobs (that's the screenshot above) and checked the page script for syntax errors.

  • Checked the layout at an exact 390px width (screenshot above).

  • Not yet done: a real video run end to end, a real YouTube upload and a screen-reader pass.

  • Ran at least one video end to end

  • Works without an API key (local or basic mode) if this touches moment picking. It doesn't touch moment picking.

  • Updated the README if setup or behaviour changed

- Settings: one-click button groups for clip count, length and aspect ratio,
  restyled dropdowns, on/off switches with explanations, visible labels,
  file drop box, errors that focus the field
- Progress: three named steps with what's happening now; YouTube uploads get
  a progress box under the clip and an uploads tray in the corner
- Clips: one row per clip with rank, score, hook and reason; Download and
  Post on the card, the rest in a ⋯ menu; any clip can fold, posted ones
  fold by themselves
- Videos: panel per video with source, time, stats and fold; older ones fold
- Accessibility: focus rings, 44px targets, skip link, live announcements,
  labelled progress bars, heading order, reduced motion
- API: DELETE /api/jobs/{id}/clips/{index} to delete one clip
- Docs: new screenshot, usage section, roadmap, UI contribution guide
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:16:09.996692Z 17165ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 9e7bdf9)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

24 - Partially compliant

Compliant requirements:

  • Redesigned the web page for clarity and accessibility
  • Added screenshots in the PR for desktop and phone width
  • Preserved core functionality while adding new UI capabilities (clip deletion, uploads tray, etc.)
  • Handled accessibility improvements (focus rings, minimum target sizes, live announcements, etc.)

Non-compliant requirements:

  • None

Requires further human verification:

  • Visual verification of UI/UX redesign, color contrasts, layout responsiveness, and accessibility compliance.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

⚠️ Review coverage: The following files were not included in this review because of the token budget:

  • static/index.html

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17165edb32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/main.py Resolved
Comment thread app/main.py Resolved
Comment thread static/index.html Resolved
…ments

- Download all copies the clip list under the lock and skips a file deleted
  while zipping, instead of failing
- Posting sends the clip's video path; the server refuses with 409 if that
  position now holds a different clip (deleted from another tab)
- Screen readers hear when a video finishes or fails
- Phone layout: clip list no longer overflows its panel, video title keeps
  its width next to the thumbnail
- Add a phone-width screenshot
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 9e7bdf9

@AbdulSamad94
AbdulSamad94 merged commit 1291d62 into main Nov 17, 2026
9 checks passed
@AbdulSamad94
AbdulSamad94 deleted the feat/ui-ux-refresh branch November 17, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant