Repository navigation
Redesign the web page: clearer settings, progress, clip list and accessibility - #25
Conversation
- Settings: one-click button groups for clip count, length and aspect ratio,
restyled dropdowns, on/off switches with explanations, visible labels,
file drop box, errors that focus the field
- Progress: three named steps with what's happening now; YouTube uploads get
a progress box under the clip and an uploads tray in the corner
- Clips: one row per clip with rank, score, hook and reason; Download and
Post on the card, the rest in a ⋯ menu; any clip can fold, posted ones
fold by themselves
- Videos: panel per video with source, time, stats and fold; older ones fold
- Accessibility: focus rings, 44px targets, skip link, live announcements,
labelled progress bars, heading order, reduced motion
- API: DELETE /api/jobs/{id}/clips/{index} to delete one clip
- Docs: new screenshot, usage section, roadmap, UI contribution guide
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PR Reviewer Guide 🔍(Review updated until commit 9e7bdf9)Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17165edb32
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ments - Download all copies the clip list under the lock and skips a file deleted while zipping, instead of failing - Posting sends the clip's video path; the server refuses with 409 if that position now holds a different clip (deleted from another tab) - Screen readers hear when a video finishes or fails - Phone layout: clip list no longer overflows its panel, video title keeps its width next to the thumbnail - Add a phone-width screenshot
|
Persistent review updated to latest commit 9e7bdf9 |
What this changes
A redesign of the web page that keeps the dark-and-yellow look and fixes the usability and accessibility problems. It adds a ⋯ menu, folding for clips and videos, and an uploads tray. Also adds deleting a single clip.
Settings
Progress
Clips and videos
Accessibility
Server:
DELETE /api/jobs/{id}/clips/{index}deletes one clip and its files. It's refused while the video is still processing or any of its clips is uploading, because uploads track their clip by position and would end up on the wrong one.Docs:
docs/youtube-setup.md: how the uploads tray and folding work.Related: #24 (help wanted for further UI/UX work)
How I tested it
pytest: 232 pass, including new tests for deleting a single clip, zipping while a clip is deleted, and refusing a post when the clip changed.Rendered the page in headless Chrome with sample finished jobs (that's the screenshot above) and checked the page script for syntax errors.
Checked the layout at an exact 390px width (screenshot above).
Not yet done: a real video run end to end, a real YouTube upload and a screen-reader pass.
Ran at least one video end to end
Works without an API key (local or basic mode) if this touches moment picking. It doesn't touch moment picking.
Updated the README if setup or behaviour changed