Bugfix/cached player#222
Open
theLee3 wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Fixes #221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent updates to Flutter, focusing on asynchronous performance improvements, led to an issue with our approach to broadcasting the cached
PlayerDataobject. The issue stems from the player data now being added to the stream before the listener is attached, leaving the listener waiting endlessly without receiving data once attached.This update corrects the issue by implementing a new approach, using a
StreamViewwrapper, in which the act of listening to the stream ensures that the cached player data is always emitted after the listener is attached.