Skip to content

Refactor/discontinue india facade - #12

Merged
umesh0492 merged 5 commits into
mainfrom
refactor/discontinue-india-facade
Sep 21, 2026
Merged

umesh0492 merged 5 commits into
mainfrom
refactor/discontinue-india-facade

Conversation

@umesh0492

Copy link
Copy Markdown
Collaborator

Description

Related Issue

Package(s) Affected

  • audit
  • export
  • india
  • notifications
  • outbox
  • pdf
  • examples/invoice_service
  • Build / Toolchain / CI

Quality Checklist

  • make fmt-check reports no unformatted files (gofmt -w .).
  • make lint passed with 0 warnings or errors (golangci-lint run ./...).
  • make test-race passed with 0 data races (go test -v -race ./...).
  • make test-integration passed (if touching outbox storage, DDL, or relay concurrency).
  • make vulncheck passed with 0 known vulnerabilities (govulncheck ./...).
  • make clean was executed before staging; workspace is clean of build and coverage artifacts.
  • Error handling follows conventions: errors wrapped with %w, sentinel errors used with errors.Is/errors.As, zero reflection in hot paths.
  • Unit tests added or updated to cover all new code paths and edge cases.
  • Godoc comments added for all newly exported types, functions, and methods.

Security Invariants Checklist

  • PDF Generator: EnableLocalFileAccess defaults to false (no SSRF or arbitrary local file read).
  • Data Export: CSV formula injection sanitization preserved (=, +, -, @, \t, \r escaped; whitespace evasion blocked).
  • Notifications & Webhooks: HMAC-SHA256 constant-time comparison and timestamp freshness verification enforced.
  • Outbox: Lease fencing tokens (lease_token UUID) verified in state transitions and table names sanitized.
  • Audit Trail: Range-partitioned DDL and append-only trigger constraints preserved.
  • Indian Fintech: Statutory validation integrity maintained (Verhoeff D5, Mod-36, PAN regex, exact integer paise arithmetic).

…-india

- Remove deprecated backward-compatibility india façade package
- Migrate examples/invoice_service to import go-fintech-india directly
- Update README and docs portal for 5 core enterprise packages and companion architecture
- Reconcile test statement coverage to 89.4% and pass all truth gates
@umesh0492
umesh0492 merged commit 77cffe5 into main Sep 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant