feat(ui): reframe Sharing tab to external-client sharing via channels#1347
Open
dolho wants to merge 1 commit into
Open
feat(ui): reframe Sharing tab to external-client sharing via channels#1347dolho wants to merge 1 commit into
dolho wants to merge 1 commit into
Conversation
Part of the Access/Sharing redesign (Epic trinity-enterprise#16). The Access tab (#17) already owns Trinity operators; this scopes the Sharing tab to the operator → external-client surface. - Google-Docs-style "Share this agent" framing; operator language removed (operators live on the Access tab). - External access policy collapsed into one **Restricted ↔ Open** segmented control over require_email/open_access (Restricted = approval-gated, Open = anyone verified; identity proof always on for external sharing). - Pending requests kept, reframed as external clients awaiting approval. - Channels rendered as compact collapsible summary rows (new ChannelDisclosure.vue). Detailed config stays reachable inside the expanded row as a non-regressing interim seam — #19 replaces the body with a modal dialog. No channel functionality removed. - Outbound file sharing + public links nudged into a separate "Distribution" section (distribution, not client access). Frontend-only; no API changes. SharingPanel prop/emit contract unchanged. Verified: both SFCs compile (vue/compiler-sfc), design-token check passes. Related to Abilityai/trinity-enterprise#18 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Resolve by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements trinity-enterprise#18 (Access/Sharing redesign epic, trinity-enterprise#16). Frontend-only; no API changes.
The Access tab (#17) already owns Trinity operators — this scopes the Sharing tab to the operator → external-client surface.
Changes
require_email/open_access:require_email:true, open_access:false(approval-gated)require_email:true, open_access:true(anyone verified)require_email:falseagent is shown by itsopen_accessflag and upgraded the next time a mode is picked (documented inline).ChannelDisclosure.vue(collapsed by default). Detailed config stays reachable inside the expanded row as a non-regressing interim seam; MCP Execution Query Tools (MCP-007) #19 ("move channel config into dialogs") swaps the body for a modal. No channel functionality removed.Acceptance criteria
Verification
vue/compiler-sfc(script setup + template).npm run check:tokenspasses.vite buildcouldn't run in my sandbox (unrelated stale-node_modulesmermaiddep gap inAgentWorkspace.vue, not touched here) — CI installs deps fresh.Notes
SharingPanelprop/emit contract (agent-name,shares,@agent-updated) unchanged.🤖 Generated with Claude Code