#188: Fix environment variable path separator on Windows #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Hugh Macdonald <hugh@hughmacdonald.co.uk>
HughMacdonald
force-pushed
the
fix-windows-plugin-path
branch
from
9bad405 to
e04f89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
This ensure that the
XSTUDIO_PLUGIN_PATHenvironment variable on Windows is split on ';' rather than ':'. Splitting on ':' causes issues with windows drive specifiers (e.g.D:/dev/xstudio_pluginis treated as 2 paths -Dand/dev/xstudio_plugin)I've tested this on Windows, and it correctly uses the plugin path now.