Replace single thiserror usage with manual trait implementations#652
Merged
DataTriny merged 1 commit intoAccessKit:mainfrom Nov 25, 2025
Merged
Replace single thiserror usage with manual trait implementations#652DataTriny merged 1 commit intoAccessKit:mainfrom
DataTriny merged 1 commit intoAccessKit:mainfrom
Conversation
jplatte
force-pushed
the
error-manual-display
branch
from
106ff97 to
62b4cce
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going to send a PR updating
thiserrorto 2.0, but noticed that with the current lockfile, all dependencies are on 1.0 and it's probably not easy to update everything to 2.0 for now. I also noticed that there's only a single use ofthiserrorthough which was trivial to replace with a manual implementation ofstd::fmt::Display+std::error::Error.If you prefer the derive though, no hard feelings :)