Draft
Conversation
gbe0808
reviewed
Aug 8, 2023
Collaborator
There was a problem hiding this comment.
ch09에서 수정하면 충돌날 수 있으니까 빼는 게 좋을듯
Collaborator
There was a problem hiding this comment.
ch09에서 수정하면 충돌날 수 있으니까 이것까지 빼는 게 좋을듯
Comment on lines
+7
to
+8
Collaborator
There was a problem hiding this comment.
Suggested change
| for i in range(len(word)-1, -1, -1): | |
| alp_value[ord(word[i]) - ord('A')] += place_value | |
| for x in word[::-1]: | |
| alp_value[ord(x) - ord('A')] += place_value |
Collaborator
There was a problem hiding this comment.
우리 struct 이름 첫 글자는 대문자로 하기로 했었나?
Collaborator
There was a problem hiding this comment.
나는 뭔가 for voted_number in voted_number_list가 더 나아보이는듯?
Comment on lines
+1
to
+5
Collaborator
There was a problem hiding this comment.
이런건 괜찮나?
Suggested change
| def how_many_pass(given_time, time_per_pass): | |
| count = 0 | |
| for t in time_per_pass: | |
| count += given_time // t | |
| return count | |
| def how_many_pass(given_time, time_per_pass): | |
| return sum(given_time // t for t in time_per_pass) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.